Refactor: based: Avoid xmlNodePtr and clean up includes

This is just some miscellaneous cleanup. For the most part, we use
xmlNode * instead of xmlNodePtr nowadays, because "const xmlNodePtr"
doesn't work. Also drop some unused includes and add some that were
missing in based_transaction.{c,h}.

Signed-off-by: Reid Wahl <nrwahl@protonmail.com>

Author: nrwahl2

daemons/based/based_transaction.c

@@ -11,8 +11,7 @@
 
 #include <stdbool.h>
 
-#include <glib.h>
-#include <libxml/tree.h>
+#include <libxml/tree.h>            // xmlNode
 
 #include "pacemaker-based.h"
 
@@ -54,8 +53,8 @@ based_transaction_source_str(const pcmk__client_t *client, const char *origin)
  * \return Standard Pacemaker return code
  */
 static int
-process_transaction_requests(xmlNodePtr transaction,
-                             const pcmk__client_t *client, const char *source)
+process_transaction_requests(xmlNode *transaction, const pcmk__client_t *client,
+                             const char *source)
 {
     for (xmlNode *request = pcmk__xe_first_child(transaction,
                                                  PCMK__XE_CIB_COMMAND, NULL,
@@ -116,10 +115,10 @@ process_transaction_requests(xmlNodePtr transaction,
  *       success, and for freeing it on failure.
  */
 int
-based_commit_transaction(xmlNodePtr transaction, const pcmk__client_t *client,
-                         const char *origin, xmlNodePtr *result_cib)
+based_commit_transaction(xmlNode *transaction, const pcmk__client_t *client,
+                         const char *origin, xmlNode **result_cib)
 {
-    xmlNodePtr saved_cib = the_cib;
+    xmlNode *saved_cib = the_cib;
     int rc = pcmk_rc_ok;
     char *source = NULL;
 

daemons/based/based_transaction.h

@@ -1,5 +1,5 @@
 /*
- * Copyright 2023 the Pacemaker project contributors
+ * Copyright 2023-2025 the Pacemaker project contributors
  *
  * The version control history for this file may have further details.
  *
@@ -10,15 +10,14 @@
 #ifndef BASED_TRANSACTION__H
 #define BASED_TRANSACTION__H
 
-#include <crm_internal.h>
+#include <libxml/tree.h>            // xmlNode
 
-#include <libxml/tree.h>
+#include <crm/common/internal.h>    // pcmk__client_t
 
 char *based_transaction_source_str(const pcmk__client_t *client,
                                    const char *origin);
 
-int based_commit_transaction(xmlNodePtr transaction,
-                             const pcmk__client_t *client,
-                             const char *origin, xmlNodePtr *result_cib);
+int based_commit_transaction(xmlNode *transaction, const pcmk__client_t *client,
+                             const char *origin, xmlNode **result_cib);
 
 #endif // BASED_TRANSACTION__H

include/crm/common/internal.h

@@ -25,6 +25,7 @@
 #include <crm/common/actions_internal.h>
 #include <crm/common/digest_internal.h>
 #include <crm/common/health_internal.h>
+#include <crm/common/ipc_internal.h>
 #include <crm/common/io_internal.h>
 #include <crm/common/iso8601_internal.h>
 #include <crm/common/mainloop_internal.h>