Refactor: based: New based_notify.h

Signed-off-by: Reid Wahl <nrwahl@protonmail.com>

Author: nrwahl2

daemons/based/Makefile.am

@@ -15,6 +15,7 @@ halibdir	= $(CRM_DAEMON_DIR)
 halib_PROGRAMS	= pacemaker-based
 
 noinst_HEADERS	= based_io.h		\
+		  based_notify.h	\
 		  based_operation.h	\
 		  based_transaction.h	\
 		  pacemaker-based.h

daemons/based/based_callbacks.c

@@ -1183,8 +1183,8 @@ cib_process_command(xmlNode *request, const cib__operation_t *operation,
                              cib_dryrun|cib_inhibit_notify|cib_transaction)) {
         pcmk__trace("Sending notifications %d",
                     pcmk__is_set(call_options, cib_dryrun));
-        cib_diff_notify(op, pcmk_rc2legacy(rc), call_id, client_id, client_name,
-                        originator, input, cib_diff);
+        based_diff_notify(op, pcmk_rc2legacy(rc), call_id, client_id,
+                          client_name, originator, input, cib_diff);
     }
 
     pcmk__log_xml_patchset(LOG_TRACE, cib_diff);

daemons/based/based_notify.c

@@ -151,9 +151,9 @@ cib_notify_send(const xmlNode *xml)
 }
 
 void
-cib_diff_notify(const char *op, int result, const char *call_id,
-                const char *client_id, const char *client_name,
-                const char *origin, xmlNode *update, xmlNode *diff)
+based_diff_notify(const char *op, int result, const char *call_id,
+                  const char *client_id, const char *client_name,
+                  const char *origin, xmlNode *update, xmlNode *diff)
 {
     int add_updates = 0;
     int add_epoch = 0;

daemons/based/based_notify.h

@@ -0,0 +1,19 @@
+/*
+ * Copyright 2025 the Pacemaker project contributors
+ *
+ * The version control history for this file may have further details.
+ *
+ * This source code is licensed under the GNU Lesser General Public License
+ * version 2.1 or later (LGPLv2.1+) WITHOUT ANY WARRANTY.
+ */
+
+#ifndef BASED_NOTIFY__H
+#define BASED_NOTIFY__H
+
+#include <libxml/tree.h>            // xmlNode
+
+void based_diff_notify(const char *op, int result, const char *call_id,
+                       const char *client_id, const char *client_name,
+                       const char *origin, xmlNode *update, xmlNode *diff);
+
+#endif // BASED_NOTIFY__H

daemons/based/pacemaker-based.h

@@ -32,6 +32,7 @@
 
 #include "based_io.h"
 #include "based_operation.h"
+#include "based_notify.h"
 #include "based_transaction.h"
 
 #include <gnutls/gnutls.h>
@@ -119,10 +120,6 @@ int cib_process_schemas(const char *op, int options, const char *section,
 void send_sync_request(const char *host);
 int sync_our_cib(xmlNode *request, bool all);
 
-void cib_diff_notify(const char *op, int result, const char *call_id,
-                     const char *client_id, const char *client_name,
-                     const char *origin, xmlNode *update, xmlNode *diff);
-
 static inline const char *
 cib_config_lookup(const char *opt)
 {