Refactor: libpacemaker: pcmk__check_rules() takes const char *const *

Signed-off-by: Reid Wahl <nrwahl@protonmail.com>

Author: nrwahl2

include/pacemaker.h

@@ -295,6 +295,7 @@ int pcmk_list_nodes(xmlNode **xml, const char *types);
  */
 int pcmk_status(xmlNodePtr *xml);
 
+// @COMPAT Change rule_ids to type const char *const * at a compatibility break
 /*!
  * \brief Check whether each rule in a list is in effect
  *

include/pcmki/pcmki_rule.h

@@ -1,5 +1,5 @@
 /*
- * Copyright 2022-2024 the Pacemaker project contributors
+ * Copyright 2022-2025 the Pacemaker project contributors
  *
  * The version control history for this file may have further details.
  *
@@ -19,7 +19,7 @@ extern "C" {
 #endif
 
 int pcmk__check_rules(pcmk__output_t *out, xmlNodePtr input,
-                      const crm_time_t *date_time, const char **rule_ids);
+                      const crm_time_t *date_time, const char *const *rule_ids);
 
 /*!
  * \internal

lib/pacemaker/pcmk_rule.c

@@ -161,7 +161,7 @@ eval_rule(pcmk_scheduler_t *scheduler, const char *rule_id, const char **error)
  */
 int
 pcmk__check_rules(pcmk__output_t *out, xmlNodePtr input, const crm_time_t *date,
-                  const char **rule_ids)
+                  const char *const *rule_ids)
 {
     pcmk_scheduler_t *scheduler = NULL;
     int rc = pcmk_rc_ok;
@@ -178,7 +178,7 @@ pcmk__check_rules(pcmk__output_t *out, xmlNodePtr input, const crm_time_t *date,
         return rc;
     }
 
-    for (const char **rule_id = rule_ids; *rule_id != NULL; rule_id++) {
+    for (const char *const *rule_id = rule_ids; *rule_id != NULL; rule_id++) {
         const char *error = NULL;
         int last_rc = eval_rule(scheduler, *rule_id, &error);
 
@@ -208,7 +208,7 @@ pcmk_check_rules(xmlNodePtr *xml, xmlNodePtr input, const crm_time_t *date,
 
     pcmk__register_lib_messages(out);
 
-    rc = pcmk__check_rules(out, input, date, rule_ids);
+    rc = pcmk__check_rules(out, input, date, (const char *const *) rule_ids);
     pcmk__xml_output_finish(out, pcmk_rc2exitc(rc), xml);
     return rc;
 }

tools/crm_rule.c

@@ -201,7 +201,7 @@ main(int argc, char **argv)
     switch(options.mode) {
         case crm_rule_mode_check:
             rc = pcmk__check_rules(out, input, rule_date,
-                                   (const char **) options.rules);
+                                   (const char *const *) options.rules);
             exit_code = pcmk_rc2exitc(rc);
             break;