Refactor: various: Replace gchar with char for function input arguments

The GLib documentation says the standard char should be preferred in new
code. The two are equivalent (via typedef).

This commit replaces gchar with char in function input arguments but
continues to use gchar for output arguments and return values. We could
make an argument for keeping gchar in those cases as a reminder to use
g_free().

https://docs.gtk.org/glib/types.html#gchar

Signed-off-by: Reid Wahl <nrwahl@protonmail.com>

Author: nrwahl2

daemons/based/pacemaker-based.c

@@ -121,7 +121,7 @@ based_metadata(pcmk__output_t *out)
 }
 
 static gboolean
-disk_writes_cb(const gchar *option_name, const gchar *optarg, void *data,
+disk_writes_cb(const char *option_name, const char *optarg, void *data,
                GError **error)
 {
     based_enable_writes(0);

daemons/execd/cts-exec-helper.c

@@ -55,15 +55,15 @@ static struct {
 } options;
 
 static gboolean
-interval_cb(const gchar *option_name, const gchar *optarg, void *data,
+interval_cb(const char *option_name, const char *optarg, void *data,
             GError **error)
 {
     return pcmk_parse_interval_spec(optarg,
                                     &options.interval_ms) == pcmk_rc_ok;
 }
 
 static gboolean
-notify_cb(const gchar *option_name, const gchar *optarg, void *data,
+notify_cb(const char *option_name, const char *optarg, void *data,
           GError **error)
 {
     if (pcmk__str_any_of(option_name, "--notify-orig", "-n", NULL)) {
@@ -76,7 +76,7 @@ notify_cb(const gchar *option_name, const gchar *optarg, void *data,
 }
 
 static gboolean
-param_key_val_cb(const gchar *option_name, const gchar *optarg, void *data,
+param_key_val_cb(const char *option_name, const char *optarg, void *data,
                  GError **error)
 {
     if (pcmk__str_any_of(option_name, "--param-key", "-k", NULL)) {

daemons/execd/remoted_pidone.c

@@ -72,7 +72,7 @@ static struct {
  *       [a-zA-Z0-9_] characters and do not start with a digit.
  */
 static bool
-valid_env_var_name(const gchar *name)
+valid_env_var_name(const char *name)
 {
     if (!isalpha(*name) && (*name != '_')) {
         // Invalid first character

daemons/fenced/cts-fence-helper.c

@@ -55,8 +55,7 @@ struct {
 };
 
 static gboolean
-mode_cb(const gchar *option_name, const gchar *optarg, void *data,
-        GError **error)
+mode_cb(const char *option_name, const char *optarg, void *data, GError **error)
 {
     if (pcmk__str_any_of(option_name, "--mainloop_api_test", "-m", NULL)) {
         options.mode = test_api_mainloop;

daemons/pacemakerd/pacemakerd.c

@@ -95,13 +95,13 @@ static pcmk__message_entry_t fmt_functions[] = {
 };
 
 static gboolean
-pid_cb(const gchar *option_name, const gchar *optarg, void *data, GError **err)
+pid_cb(const char *option_name, const char *optarg, void *data, GError **err)
 {
     return TRUE;
 }
 
 static gboolean
-standby_cb(const gchar *option_name, const gchar *optarg, void *data,
+standby_cb(const char *option_name, const char *optarg, void *data,
            GError **err)
 {
     options.standby = TRUE;

include/crm/common/cmdline_internal.h

@@ -117,7 +117,7 @@ void pcmk__add_arg_group(GOptionContext *context, const char *name,
  *
  * \param[in,out] argv  Command line (typically from pcmk__cmdline_preproc())
  */
-gchar *pcmk__quote_cmdline(gchar **argv);
+gchar *pcmk__quote_cmdline(char **argv);
 
 /*!
  * \internal

include/crm/common/logging_internal.h

@@ -405,7 +405,7 @@ void pcmk__log_xml_patchset_as(const char *file, const char *function,
  */
 void pcmk__cli_init_logging(const char *name, unsigned int verbosity);
 
-void pcmk__add_logfiles(gchar **log_files, pcmk__output_t *out);
+void pcmk__add_logfiles(char **log_files, pcmk__output_t *out);
 
 #ifdef __cplusplus
 }

include/crm/common/nvpair_internal.h

@@ -47,7 +47,7 @@ int pcmk__cmp_nvpair_blocks(const void *a, const void *b, void *user_data);
 
 void pcmk__unpack_nvpair_block(void *data, void *user_data);
 
-int pcmk__scan_nvpair(const gchar *input, gchar **name, gchar **value);
+int pcmk__scan_nvpair(const char *input, gchar **name, gchar **value);
 char *pcmk__format_nvpair(const char *name, const char *value,
                           const char *units);
 

include/crm/common/strings_internal.h

@@ -164,7 +164,7 @@ pcmk__intkey_table_remove(GHashTable *hash_table, int key)
 }
 
 bool pcmk__str_in_list(const char *str, const GList *list, uint32_t flags);
-bool pcmk__g_strv_contains(gchar **strv, const gchar *str);
+bool pcmk__g_strv_contains(char **strv, const char *str);
 
 bool pcmk__strcase_any_of(const char *s, ...) G_GNUC_NULL_TERMINATED;
 bool pcmk__str_any_of(const char *s, ...) G_GNUC_NULL_TERMINATED;

lib/common/cmdline.c

@@ -18,7 +18,7 @@
 #include <crm/common/util.h>
 
 static gboolean
-bump_verbosity(const gchar *option_name, const gchar *optarg, void *data,
+bump_verbosity(const char *option_name, const char *optarg, void *data,
                GError **error)
 {
     pcmk__common_args_t *common_args = (pcmk__common_args_t *) data;
@@ -146,7 +146,7 @@ pcmk__add_arg_group(GOptionContext *context, const char *name,
 }
 
 gchar *
-pcmk__quote_cmdline(gchar **argv)
+pcmk__quote_cmdline(char **argv)
 {
     GString *cmdline = NULL;