Refactor: based: Drop based_process_request last cib_discard_reply check

It's redundant. If needs_reply is true, then cib_discard_reply is not
set. (If cib_discard_reply is set, then we set needs_reply and
local_notify to false earlier in based_process_request().)

Signed-off-by: Reid Wahl <nrwahl@protonmail.com>

Author: nrwahl2

daemons/based/based_callbacks.c

@@ -848,8 +848,7 @@ based_process_request(xmlNode *request, bool privileged,
                     pcmk__s(originator, "local"), client_name, call_id,
                     (local_notify? " with local notification" : ""));
 
-    } else if (needs_reply && !stand_alone && (client == NULL)
-               && !pcmk__is_set(call_options, cib_discard_reply)) {
+    } else if (needs_reply && !stand_alone && (client == NULL)) {
         send_peer_reply(reply, originator);
     }