Skip to content

Commit b5997c4

Browse files
committed
Refactor: libstonithd: Drop null_field Coverity suppression
Coverity was flagging this as an error because it didn't know whether pcmk__trace() might set entry->notify to NULL. Coverity doesn't have a model for qb_log_from_external_source(), which pcmk__trace() calls. We could provide a model, but instead we just drop the "%p", which doesn't seem helpful. Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
1 parent 6a3d788 commit b5997c4

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

lib/fencing/st_client.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1560,14 +1560,14 @@ stonith_send_notification(gpointer data, gpointer user_data)
15601560
return;
15611561

15621562
} else if (!pcmk__str_eq(entry->event, event, pcmk__str_none)) {
1563-
pcmk__trace("Skipping callback - event mismatch %p/%s vs. %s", entry, entry->event, event);
1563+
pcmk__trace("Skipping callback - event mismatch %s vs. %s",
1564+
entry->event, event);
15641565
return;
15651566
}
15661567

15671568
st_event = xml_to_event(blob->xml);
15681569

1569-
pcmk__trace("Invoking callback for %p/%s event...", entry, event);
1570-
// coverity[null_field]
1570+
pcmk__trace("Invoking callback for %s event...", event);
15711571
entry->notify(blob->stonith, st_event);
15721572
pcmk__trace("Callback invoked...");
15731573

0 commit comments

Comments
 (0)