Refactor: libpe_status: Drop pcmk__is_set_recursive() any argument

We always pass true now.

Signed-off-by: Reid Wahl <nrwahl@protonmail.com>

Author: nrwahl2

include/crm/pengine/internal.h

@@ -259,8 +259,7 @@ pe_base_name_eq(const pcmk_resource_t *rsc, const char *id)
 int pe__target_rc_from_xml(const xmlNode *xml_op);
 
 int pe__cmp_node_name(const void *a, const void *b);
-bool pcmk__is_set_recursive(const pcmk_resource_t *rsc, uint64_t flag,
-                            bool any);
+bool pcmk__is_set_recursive(const pcmk_resource_t *rsc, uint64_t flag);
 
 pcmk__op_digest_t *pe__calculate_digests(pcmk_resource_t *rsc, const char *task,
                                          unsigned int *interval_ms,

lib/pacemaker/pcmk_sched_bundle.c

@@ -499,7 +499,7 @@ replica_apply_coloc_score(const pcmk__bundle_replica_t *replica,
     chosen = container->priv->fns->location(container, NULL,
                                             pcmk__rsc_node_assigned);
     if ((chosen == NULL)
-        || pcmk__is_set_recursive(container, pcmk__rsc_blocked, true)) {
+        || pcmk__is_set_recursive(container, pcmk__rsc_blocked)) {
         return true;
     }
 

lib/pacemaker/pcmk_sched_clone.c

@@ -343,7 +343,7 @@ pcmk__clone_apply_coloc_score(pcmk_resource_t *dependent,
             chosen = instance->priv->fns->location(instance, NULL,
                                                    pcmk__rsc_node_assigned);
             if ((chosen != NULL)
-                && !pcmk__is_set_recursive(instance, pcmk__rsc_blocked, true)) {
+                && !pcmk__is_set_recursive(instance, pcmk__rsc_blocked)) {
                 pcmk__rsc_trace(primary, "Allowing %s: %s %d",
                                 colocation->id, pcmk__node_name(chosen),
                                 chosen->assign->score);

lib/pacemaker/pcmk_sched_instances.c

@@ -1114,7 +1114,7 @@ pcmk__instance_matches(const pcmk_resource_t *instance, const pcmk_node_t *node,
         return false;
     }
 
-    if (!pcmk__is_set_recursive(instance, pcmk__rsc_blocked, true)) {
+    if (!pcmk__is_set_recursive(instance, pcmk__rsc_blocked)) {
         uint32_t target = pcmk__rsc_node_assigned;
 
         if (current) {

lib/pengine/clone.c

@@ -544,38 +544,23 @@ rsc_managed_recursive(const pcmk_resource_t *rsc)
 }
 
 bool
-pcmk__is_set_recursive(const pcmk_resource_t *rsc, uint64_t flag, bool any)
+pcmk__is_set_recursive(const pcmk_resource_t *rsc, uint64_t flag)
 {
-    const bool all = !any;
-    bool is_set = pcmk__is_set(rsc->flags, flag);
-
-    if (any && is_set) {
+    if (pcmk__is_set(rsc->flags, flag)) {
         return true;
     }
 
-    if (all && !is_set) {
-        return false;
-    }
-
     for (const GList *iter = rsc->priv->children; iter != NULL;
          iter = iter->next) {
 
-        is_set = pcmk__is_set_recursive(iter->data, flag, any);
+        const pcmk_resource_t *child_rsc = iter->data;
 
-        if (any && is_set) {
+        if (pcmk__is_set_recursive(child_rsc, flag)) {
             return true;
         }
-
-        if (all && !is_set) {
-            return false;
-        }
     }
 
-    /* If all is true, then flag was set for rsc and all of its descendants.
-     * Otherwise, any is true, and flag was not set for rsc or any of its
-     * descendants.
-     */
-    return all;
+    return false;
 }
 
 PCMK__OUTPUT_ARGS("clone", "uint32_t", "pcmk_resource_t *", "GList *",
@@ -744,10 +729,9 @@ pe__clone_default(pcmk__output_t *out, va_list args)
                 pcmk__insert_dup(stopped, child_rsc->id, "Stopped");
             }
 
-        } else if (pcmk__is_set_recursive(child_rsc, pcmk__rsc_removed, true)
+        } else if (pcmk__is_set_recursive(child_rsc, pcmk__rsc_removed)
                    || !rsc_managed_recursive(child_rsc)
-                   || pcmk__is_set_recursive(child_rsc, pcmk__rsc_failed,
-                                             true)) {
+                   || pcmk__is_set_recursive(child_rsc, pcmk__rsc_failed)) {
 
             // Print individual instance when active removed/unmanaged/failed
             print_full = TRUE;