API: libcrmcommon: Deprecate crm_time_add_years()

External callers have no need to add years to a crm_time_t object.
Pacemaker should not be used for general-purpose date/time manipulation.

Signed-off-by: Reid Wahl <nrwahl@protonmail.com>

Author: nrwahl2

include/crm/common/iso8601.h

@@ -53,9 +53,6 @@ typedef struct crm_time_s crm_time_t;
  */
 crm_time_t *crm_time_new(const char *string);
 
-/* All crm_time_add_... functions support negative values */
-void crm_time_add_years(crm_time_t * dt, int value);
-
 #ifdef __cplusplus
 }
 #endif

include/crm/common/iso8601_compat.h

@@ -172,6 +172,9 @@ void crm_time_add_weeks(crm_time_t *dt, int value);
 //! \deprecated Do not use
 void crm_time_add_months(crm_time_t *dt, int value);
 
+//! \deprecated Do not use
+void crm_time_add_years(crm_time_t *dt, int value);
+
 #ifdef __cplusplus
 }
 #endif

lib/common/iso8601.c

@@ -1781,12 +1781,6 @@ pcmk__time_compare(const crm_time_t *a, const crm_time_t *b)
     return rc;
 }
 
-void
-crm_time_add_years(crm_time_t *dt, int value)
-{
-    pcmk__time_add_years(dt, value);
-}
-
 static void
 ha_get_tm_time(struct tm *target, const crm_time_t *source)
 {
@@ -2518,5 +2512,11 @@ crm_time_add_months(crm_time_t *dt, int value)
     add_months(dt, value);
 }
 
+void
+crm_time_add_years(crm_time_t *dt, int value)
+{
+    pcmk__time_add_years(dt, value);
+}
+
 // LCOV_EXCL_STOP
 // End deprecated API