Skip to content

Commit cba948f

Browse files
committed
Refactor: libpe_status: Drop NULL_FIELD coverity suppression
Coverity thinks that passing replica to g_list_append() can set replica->child to NULL. Opened support case 03704783 with Black Duck (Coverity vendor), for them to investigate this further. Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
1 parent b5997c4 commit cba948f

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

lib/pengine/bundle.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1352,12 +1352,11 @@ create_child_resource(pcmk_resource_t *rsc, xmlNode *clone_xml,
13521352
}
13531353

13541354
allocate_ip(rsc, replica, buffer);
1355-
bundle_data->replicas = g_list_append(bundle_data->replicas, replica);
13561355

1357-
// coverity[null_field : FALSE] replica->child can't be NULL here
13581356
bundle_data->attribute_target =
13591357
g_hash_table_lookup(replica->child->priv->meta,
13601358
PCMK_META_CONTAINER_ATTRIBUTE_TARGET);
1359+
bundle_data->replicas = g_list_append(bundle_data->replicas, replica);
13611360
}
13621361

13631362
bundle_data->container_host_options = g_string_free(buffer, false);

0 commit comments

Comments
 (0)