Refactor: various: Replace gconstpointer with const void *

The GLib documentation says the standard const void * should be
preferred in new code. The two are equivalent (via typedef).

https://docs.gtk.org/glib/types.html#gconstpointer

Signed-off-by: Reid Wahl <nrwahl@protonmail.com>

Author: nrwahl2

daemons/fenced/fenced_history.c

@@ -145,7 +145,7 @@ stonith_fence_history_cleanup(const char *target,
  *         0 if the values are equal, and a positive integer if \p a is greater)
  */
 static int
-cmp_op_by_completion(gconstpointer a, gconstpointer b)
+cmp_op_by_completion(const void *a, const void *b)
 {
     const remote_fencing_op_t *op1 = a;
     const remote_fencing_op_t *op2 = b;

daemons/fenced/fenced_remote.c

@@ -89,7 +89,7 @@ static int get_op_total_timeout(const remote_fencing_op_t *op,
                                 const peer_device_info_t *chosen_peer);
 
 static int
-sort_strings(gconstpointer a, gconstpointer b)
+sort_strings(const void *a, const void *b)
 {
     return strcmp(a, b);
 }
@@ -2110,7 +2110,7 @@ request_peer_fencing(remote_fencing_op_t *op, peer_device_info_t *peer)
  *         if the first value comes after the second."
  */
 static int
-sort_peers(gconstpointer a, gconstpointer b)
+sort_peers(const void *a, const void *b)
 {
     const peer_device_info_t *peer_a = a;
     const peer_device_info_t *peer_b = b;

include/crm/common/nvpair_internal.h

@@ -43,7 +43,7 @@ typedef struct {
     crm_time_t *next_change;
 } pcmk__nvpair_unpack_t;
 
-int pcmk__cmp_nvpair_blocks(gconstpointer a, gconstpointer b, void *user_data);
+int pcmk__cmp_nvpair_blocks(const void *a, const void *b, void *user_data);
 
 void pcmk__unpack_nvpair_block(void *data, void *user_data);
 

include/crm/pengine/internal.h

@@ -231,7 +231,7 @@ void resource_location(pcmk_resource_t *rsc, const pcmk_node_t *node, int score,
                        const char *tag, pcmk_scheduler_t *scheduler);
 
 int pe__is_newer_op(const xmlNode *xml_a, const xmlNode *xml_b);
-int sort_op_by_callid(gconstpointer a, gconstpointer b);
+int sort_op_by_callid(const void *a, const void *b);
 gboolean get_target_role(const pcmk_resource_t *rsc, enum rsc_role_e *role);
 void pe__set_next_role(pcmk_resource_t *rsc, enum rsc_role_e role,
                        const char *why);
@@ -258,7 +258,7 @@ pe_base_name_eq(const pcmk_resource_t *rsc, const char *id)
 
 int pe__target_rc_from_xml(const xmlNode *xml_op);
 
-int pe__cmp_node_name(gconstpointer a, gconstpointer b);
+int pe__cmp_node_name(const void *a, const void *b);
 bool is_set_recursive(const pcmk_resource_t *rsc, long long flag, bool any);
 
 pcmk__op_digest_t *pe__calculate_digests(pcmk_resource_t *rsc, const char *task,

lib/cib/cib_client.c

@@ -28,7 +28,7 @@
 static GHashTable *cib_op_callback_table = NULL;
 
 static int
-ciblib_GCompareFunc(gconstpointer a, gconstpointer b)
+ciblib_GCompareFunc(const void *a, const void *b)
 {
     int rc = 0;
     const cib_notify_client_t *a_client = a;

lib/common/nvpair.c

@@ -581,7 +581,7 @@ crm_meta_value(GHashTable *meta, const char *attr_name)
  * \note This is suitable for use as a GList sorting function.
  */
 int
-pcmk__cmp_nvpair_blocks(gconstpointer a, gconstpointer b, void *user_data)
+pcmk__cmp_nvpair_blocks(const void *a, const void *b, void *user_data)
 {
     const xmlNode *pair_a = a;
     const xmlNode *pair_b = b;
@@ -659,7 +659,7 @@ pcmk__cmp_nvpair_blocks(gconstpointer a, gconstpointer b, void *user_data)
 #include <crm/common/nvpair_compat.h>
 
 static int
-pcmk__compare_nvpair(gconstpointer a, gconstpointer b)
+pcmk__compare_nvpair(const void *a, const void *b)
 {
     int rc = 0;
     const pcmk_nvpair_t *pair_a = a;

lib/common/patchset.c

@@ -622,7 +622,7 @@ typedef struct {
 } xml_change_obj_t;
 
 static int
-sort_change_obj_by_position(gconstpointer a, gconstpointer b)
+sort_change_obj_by_position(const void *a, const void *b)
 {
     const xml_change_obj_t *change_obj_a = a;
     const xml_change_obj_t *change_obj_b = b;

lib/common/schemas.c

@@ -483,7 +483,7 @@ pcmk__load_schemas_from_dir(const char *dir)
 }
 
 static int
-schema_sort_GCompareFunc(gconstpointer a, gconstpointer b)
+schema_sort_GCompareFunc(const void *a, const void *b)
 {
     const pcmk__schema_t *schema_a = a;
     const pcmk__schema_t *schema_b = b;

lib/common/strings.c

@@ -422,7 +422,7 @@ pcmk_parse_interval_spec(const char *input, unsigned int *result_ms)
  * in the transition graph.
  */
 static unsigned int
-pcmk__str_hash(gconstpointer v)
+pcmk__str_hash(const void *v)
 {
     const signed char *p;
     guint32 h = 0;
@@ -472,13 +472,13 @@ pcmk__insert_dup(GHashTable *table, const char *name, const char *value)
 
 /* used with hash tables where case does not matter */
 static gboolean
-pcmk__strcase_equal(gconstpointer a, gconstpointer b)
+pcmk__strcase_equal(const void *a, const void *b)
 {
     return pcmk__str_eq((const char *)a, (const char *)b, pcmk__str_casei);
 }
 
 static unsigned int
-pcmk__strcase_hash(gconstpointer v)
+pcmk__strcase_hash(const void *v)
 {
     const signed char *p;
     guint32 h = 0;
@@ -944,7 +944,7 @@ struct str_in_list_data {
  *         (according to \p b->flags)
  */
 static int
-cmp_str_in_list(gconstpointer a, gconstpointer b)
+cmp_str_in_list(const void *a, const void *b)
 {
     const char *element = a;
     const struct str_in_list_data *data = b;

lib/common/xml_element.c

@@ -287,7 +287,7 @@ pcmk__xe_copy_attrs(xmlNode *target, const xmlNode *src, uint32_t flags)
  *                   lexicographically
  */
 static int
-compare_xml_attr(gconstpointer a, gconstpointer b)
+compare_xml_attr(const void *a, const void *b)
 {
     const xmlAttr *attr_a = a;
     const xmlAttr *attr_b = b;