API: libcrmcommon: Deprecate crm_time_parse_duration()

Pacemaker parses durations from strings in a few places. However,
there is no need for external code to do this for the purpose of
administering Pacemaker. Pacemaker should not be used for
general-purpose date/time manipulation.

Signed-off-by: Reid Wahl <nrwahl@protonmail.com>

Author: nrwahl2

include/crm/common/iso8601.h

@@ -69,8 +69,6 @@ char *crm_time_as_string(const crm_time_t *dt, int flags);
 #define crm_time_epoch             0x200
 #define crm_time_usecs             0x400
 
-crm_time_t *crm_time_parse_duration(const char *duration_str);
-
 int crm_time_compare(const crm_time_t *a, const crm_time_t *b);
 
 int crm_time_get_timeofday(const crm_time_t *dt, uint32_t *h, uint32_t *m,

include/crm/common/iso8601_compat.h

@@ -82,6 +82,10 @@ crm_time_period_t *crm_time_parse_period(const char *period_str);
 //! \deprecated Do not use
 crm_time_t *crm_time_calculate_duration(const crm_time_t *dt,
                                         const crm_time_t *value);
+
+//! \deprecated Do not use
+crm_time_t *crm_time_parse_duration(const char *duration_str);
+
 #ifdef __cplusplus
 }
 #endif

lib/common/iso8601.c

@@ -1357,23 +1357,6 @@ pcmk__time_parse_duration(const char *period_s)
     return NULL;
 }
 
-/*!
- * \brief Parse a time duration from an ISO 8601 duration specification
- *
- * \param[in] period_s  ISO 8601 duration specification (optionally followed by
- *                      whitespace, after which the rest of the string will be
- *                      ignored)
- *
- * \return New time object on success, NULL (and set errno) otherwise
- * \note It is the caller's responsibility to return the result using
- *       crm_time_free().
- */
-crm_time_t *
-crm_time_parse_duration(const char *period_s)
-{
-    return pcmk__time_parse_duration(period_s);
-}
-
 /*!
  * \internal
  * \brief Set one time object to another if the other is earlier
@@ -2433,5 +2416,11 @@ crm_time_calculate_duration(const crm_time_t *dt, const crm_time_t *value)
     return subtract_time(dt, value, true);
 }
 
+crm_time_t *
+crm_time_parse_duration(const char *period_s)
+{
+    return pcmk__time_parse_duration(period_s);
+}
+
 // LCOV_EXCL_STOP
 // End deprecated API