Refactor: daemons: Make unknown request messages more similar.

Some (but not all) daemons can handle both IPC and CPG message types, so
the unknown request message should be able to print both.  I'm doing
this even on daemons that only handle one type in the interest of making
these functions as similar as possible.

Other daemons have a different style of unknown request function.
Rather than sort that out right now (I think we'll need to figure out
the ACK vs NACK thing first), I'm just removing the message type detail
from the result.

Author: clumens

daemons/attrd/attrd_messages.c

@@ -55,7 +55,8 @@ remove_unsupported_sync_points(pcmk__request_t *request)
 static xmlNode *
 handle_unknown_request(pcmk__request_t *request)
 {
-    crm_err("Unknown IPC request %s from %s %s",
+    crm_err("Unknown %s request %s from %s %s",
+            (request->ipc_client != NULL) ? "IPC" : "CPG",
             request->op, pcmk__request_origin_type(request),
             pcmk__request_origin(request));
     pcmk__format_result(&request->result, CRM_EX_PROTOCOL, PCMK_EXEC_INVALID,

daemons/execd/execd_messages.c

@@ -402,7 +402,7 @@ handle_unknown_request(pcmk__request_t *request)
                        PCMK__XE_NACK, NULL, CRM_EX_PROTOCOL);
 
     pcmk__format_result(&request->result, CRM_EX_PROTOCOL, PCMK_EXEC_INVALID,
-                        "Unknown IPC request type '%s' (bug?)",
+                        "Unknown request type '%s' (bug?)",
                         pcmk__s(request->op, ""));
     return NULL;
 }

daemons/pacemakerd/pcmkd_messages.c

@@ -153,7 +153,7 @@ handle_unknown_request(pcmk__request_t *request)
                        PCMK__XE_ACK, NULL, CRM_EX_PROTOCOL);
 
     pcmk__format_result(&request->result, CRM_EX_PROTOCOL, PCMK_EXEC_INVALID,
-                        "Unknown IPC request type '%s' (bug?)",
+                        "Unknown request type '%s' (bug?)",
                         pcmk__s(request->op, ""));
     return NULL;
 }

daemons/schedulerd/schedulerd_messages.c

@@ -190,7 +190,7 @@ handle_unknown_request(pcmk__request_t *request)
                        PCMK__XE_ACK, NULL, CRM_EX_PROTOCOL);
 
     pcmk__format_result(&request->result, CRM_EX_PROTOCOL, PCMK_EXEC_INVALID,
-                        "Unknown IPC request type '%s' (bug?)",
+                        "Unknown request type '%s' (bug?)",
                         pcmk__s(request->op, ""));
     return NULL;
 }