Fixed warnings and optional delegate methods

Author: romanbaitaliuk

Sources/CWSDelegate.swift

@@ -26,16 +26,3 @@ import Foundation
 
     @objc optional func encode(message: Any?) -> Any?
 }
-
-extension CWSDelegate {
-    
-    /// Custom decode that user can implement
-    func decode(message: Any?) -> Any? {
-        return nil
-    }
-    
-    /// Custom encode that user can implement
-    func encode(message: Any?) -> Any? {
-        return nil
-    }
-}

Sources/CWSParser.swift

@@ -117,20 +117,20 @@ extension CWSParser {
 
     private func handleP(with data: [Any]) {
         let channelName = String(describing: data[1])
-        let decodedMessage = self.mSocket.delegate?.decode(message: data[2]) ?? data[2]
+        let decodedMessage = self.mSocket.delegate?.decode?(message: data[2]) ?? data[2]
         self.mSocket.getChannel(by: channelName)?.onMessage(data: decodedMessage)
     }
 
     private func handleE(with data: [Any]) {
         let event = String(describing: data[1])
-        let decodedMessage = self.mSocket.delegate?.decode(message: data[2]) ?? data[2]
+        let decodedMessage = self.mSocket.delegate?.decode?(message: data[2]) ?? data[2]
         self.mSocket.emit(event: event, data: decodedMessage)
     }
 
     private func handleS(with data: [Any]) {
         switch String(describing: data[1]) {
         case "c":
-            let decodedMessage = self.mSocket.delegate?.decode(message: data[2]) ?? data[2]
+            let decodedMessage = self.mSocket.delegate?.decode?(message: data[2]) ?? data[2]
             guard let pingJSON = decodedMessage as? [String: Any] else {
                 self.mSocket.delegate?.onError(error: CWSError.pingJSONCastError(decodedMessage))
                 return

Sources/ClusterWS.swift

@@ -156,17 +156,17 @@ extension ClusterWS {
 
 extension ClusterWS {
     open func send(event: String, data: Any? = nil, type: MessageType) {
-        let customEncodedData = self.delegate?.encode(message: data)
+        let customEncodedData = self.delegate?.encode?(message: data) ?? data
         if self.mUseBinary {
             guard let encodedData = self.mParser.encode(event: event,
-                                                                      data: customEncodedData ?? data,
+                                                                      data: customEncodedData,
                                                                       type: type)?.data(using: .utf8) else {
                                                                         self.delegate?.onError(error: CWSError.JSONStringifyError(data))
                                                                         return
             }
             self.mWebSocket?.send(encodedData)
         } else {
-            guard let anyData = self.mParser.encode(event: event, data: customEncodedData ?? data, type: type) else {
+            guard let anyData = self.mParser.encode(event: event, data: customEncodedData, type: type) else {
                 self.delegate?.onError(error: CWSError.JSONStringifyError(data))
                 return
             }

Sources/WebSocket.swift

@@ -1024,7 +1024,7 @@ private class InnerWebSocket: Hashable {
 			security = .none
 		}
 
-		var path = CFURLCopyPath(req.url! as CFURL!) as String
+        var path = CFURLCopyPath(req.url! as CFURL?) as String
         if path == "" {
             path = "/"
         }
@@ -1058,7 +1058,7 @@ private class InnerWebSocket: Hashable {
         var (rdo, wro) : (InputStream?, OutputStream?)
         var readStream:  Unmanaged<CFReadStream>?
         var writeStream: Unmanaged<CFWriteStream>?
-        CFStreamCreatePairWithSocketToHost(nil, addr[0] as CFString!, UInt32(Int(addr[1])!), &readStream, &writeStream);
+        CFStreamCreatePairWithSocketToHost(nil, addr[0] as CFString?, UInt32(Int(addr[1])!), &readStream, &writeStream);
         rdo = readStream!.takeRetainedValue()
         wro = writeStream!.takeRetainedValue()
         (rd, wr) = (rdo!, wro!)

Tests/CWSChannelTests.swift

@@ -9,13 +9,14 @@
 import XCTest
 import ClusterWS_Client_Swift
 
+//@testable import ClusterWS
 class CWSChannelTests: XCTestCase {
     var webSocket: ClusterWS!
 
     override func setUp() {
         super.setUp()
         // Put setup code here. This method is called before the invocation of each test method in the class.
-        self.webSocket = ClusterWS(url: "wss://localhost:8080")
+        self.webSocket = ClusterWS(url: "ws://localhost:8080")
         self.webSocket.setReconnection(autoReconnect: true)
     }
 

Tests/CWSReconnectionTests.swift

@@ -9,12 +9,14 @@
 import XCTest
 import ClusterWS_Client_Swift
 
+//@testable import ClusterWS
 extension CWSReconnectionTests: CWSDelegate {
+    
     func onConnect() {
         print("Connected")
     }
 
-    func onDisconnect(code: Int?, reason: String?) {
+    func onDisconnect(code: Int, reason: String) {
         print("Disconnected")
         self.currentAttamts += 1
     }
@@ -45,12 +47,12 @@ class CWSReconnectionTests: XCTestCase {
     }
 
     private func initSocketWithWrongUrl() {
-        self.webSocket = ClusterWS(url: "wss://localhost:0000")
+        self.webSocket = ClusterWS(url: "ws://localhost:0000")
         self.webSocket.delegate = self
     }
 
     private func initSocketWithRightUrl() {
-        self.webSocket = ClusterWS(url: "wss://localhost:8080")
+        self.webSocket = ClusterWS(url: "ws://localhost:8080")
         self.webSocket.delegate = self
     }
 

Tests/ClusterWSTests.swift

@@ -7,8 +7,9 @@
 //
 
 import XCTest
+import ClusterWS_Client_Swift
 
-@testable import ClusterWS
+//@testable import ClusterWS
 class ClusterWSTests: XCTestCase {
     var webSocket: ClusterWS!