Skip to content

Commit 9e096aa

Browse files
committed
Fix false positives in trigger self-reference detection
1 parent 14646c5 commit 9e096aa

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

src/TSMapEditor/UI/Windows/TriggersWindow.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -782,12 +782,6 @@ private void ShowReferences()
782782
bool selfReference = false;
783783
var allReferringTriggers = map.Triggers.FindAll(trig =>
784784
{
785-
if (trig == editedTrigger)
786-
{
787-
selfReference = true;
788-
return false;
789-
}
790-
791785
foreach (var triggerAction in trig.Actions)
792786
{
793787
if (!map.EditorConfig.TriggerEventTypes.ContainsKey(triggerAction.ActionIndex))
@@ -800,6 +794,12 @@ private void ShowReferences()
800794
string paramValue = triggerAction.Parameters[i];
801795
if (actionType.Parameters[i].TriggerParamType == TriggerParamType.Trigger && paramValue == editedTrigger.ID)
802796
{
797+
if (trig == editedTrigger)
798+
{
799+
selfReference = true;
800+
return false;
801+
}
802+
803803
return true;
804804
}
805805
}

0 commit comments

Comments
 (0)