Add Home Cell and Theme keys to Basic Options window#232
Merged
Conversation
Rampastring
requested changes
May 4, 2025
Rampastring
requested changes
May 6, 2025
Rampastring
requested changes
May 7, 2025
Member
Rampastring
left a comment
Rampastring
left a comment
There was a problem hiding this comment.
Looks good aside from defining btnApply as a field.
| private XNACheckBox chkTiberiumDeathToVisceroid; | ||
| private XNACheckBox chkFreeRadar; | ||
| private XNACheckBox chkRequiredAddOn; | ||
| private EditorButton btnApply; |
Member
There was a problem hiding this comment.
As far as I can see, there is no reason for us to define btnApply as a field as it is only used in Initialize, where it was previously fetched and used. It has no reason to exist elsewhere. Was there a reason why you added it here?
Rampastring
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two new keys to the Basic Options window:
Additionally, changes the text in the Place Waypoints from
0-99to0-699, as we now support 700 waypoints.