Skip to content

Fix maps#901

Closed
G-LimeJuice wants to merge 3 commits into
CnCNet:developfrom
G-LimeJuice:fix-map
Closed

Fix maps#901
G-LimeJuice wants to merge 3 commits into
CnCNet:developfrom
G-LimeJuice:fix-map

Conversation

@G-LimeJuice

@G-LimeJuice G-LimeJuice commented May 2, 2026

Copy link
Copy Markdown

Map Name : [8] Near Ore Far
Description : I'll clear the remaining gems at the top near spot 1 since its hard to place a building there
Screenshot 2026-05-03 013608
image

I'll clear the remaining gems at the top near spot 2 since its hard to place a building there
@brichardson1991

Copy link
Copy Markdown
Collaborator

@CnCRAZER what do you think, it's a original Westwood map, but surely this should be fixed right?

@G-LimeJuice G-LimeJuice changed the title Edit Map "Near Ore Far" Fix maps May 4, 2026
Map Name : Hammer and Sickle
Description : I removed something remaining of bridge
@G-LimeJuice

G-LimeJuice commented May 4, 2026

Copy link
Copy Markdown
Author

Map Name : [2] Hammer and Sickle
Description : I removed something remaining of bridge at middle
Screenshot 2026-05-04 153657

@CCCP84

CCCP84 commented May 8, 2026

Copy link
Copy Markdown
Contributor

Many sections have been changed in the map file. Did you do this intentionally, or did the editor overwrite these sections? If you only wanted to change the overlays, maybe you should just change the overlay section?

@SadPencil

Copy link
Copy Markdown
Member

If this is an official Westwood map I don't think we should fix this. Otherwise there are too many maps can be fixed

@CnCRAZER

CnCRAZER commented May 8, 2026

Copy link
Copy Markdown
Collaborator

Removing the bridge overlay that's ontop of land is ok imo

@SadPencil

SadPencil commented May 8, 2026

Copy link
Copy Markdown
Member

Also, no matter what our final decision is, this should be a per-map PR instead of bundle things together.

@CCCP84 I think you are right. For GerHaLe's PR we need a thorough review on every change and if the final decision were supporting a PR, we might need to re-implement the changes if necessary.

@CCCP84

CCCP84 commented May 8, 2026

Copy link
Copy Markdown
Contributor

If this is an official Westwood map I don't think we should fix this. Otherwise there are too many maps can be fixed

I believe that if there are any obvious flaws in the maps, they should be corrected. These two cases presented in this PR are obvious flaws and should be corrected, in my opinion. However, only the overlay section needs to be changed.

@CnCRAZER

Copy link
Copy Markdown
Collaborator

image

@G-LimeJuice this pr will not be merged in with this. Also, only the overlay section in the map files need changes

@G-LimeJuice

Copy link
Copy Markdown
Author

image

@G-LimeJuice this pr will not be merged in with this. Also, only the overlay section in the map files need changes

I didnt add this code
Why did WAE add something code in map file?

@G-LimeJuice

Copy link
Copy Markdown
Author

@CnCRAZER done

@SadPencil SadPencil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. as long as the PR is titled "Fix maps" (contains too little information) and the PR modifies multiple official maps, it cannot be merged no matter in the end whether we allow modifying official maps or not
  2. CCCP84 said "Many sections have been changed in the map file". It is unclear whether your latest commit solves all unnecessary changes. Please explicitly answer that

I suggest you submit two PRs, where one PR modifies one official map only. Explicitly state the motivation (why modifying it, like what's wrong with the current map), the diff (what you have modified), and does this change bring any in-game differences than the visual

@G-LimeJuice G-LimeJuice deleted the fix-map branch May 23, 2026 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants