Fix maps#901
Conversation
I'll clear the remaining gems at the top near spot 2 since its hard to place a building there
|
@CnCRAZER what do you think, it's a original Westwood map, but surely this should be fixed right? |
Map Name : Hammer and Sickle Description : I removed something remaining of bridge
|
Many sections have been changed in the map file. Did you do this intentionally, or did the editor overwrite these sections? If you only wanted to change the overlays, maybe you should just change the overlay section? |
|
If this is an official Westwood map I don't think we should fix this. Otherwise there are too many maps can be fixed |
|
Removing the bridge overlay that's ontop of land is ok imo |
|
Also, no matter what our final decision is, this should be a per-map PR instead of bundle things together. @CCCP84 I think you are right. For GerHaLe's PR we need a thorough review on every change and if the final decision were supporting a PR, we might need to re-implement the changes if necessary. |
I believe that if there are any obvious flaws in the maps, they should be corrected. These two cases presented in this PR are obvious flaws and should be corrected, in my opinion. However, only the overlay section needs to be changed. |
|
@G-LimeJuice this pr will not be merged in with this. Also, only the overlay section in the map files need changes |
I didnt add this code |
|
@CnCRAZER done |
There was a problem hiding this comment.
- as long as the PR is titled "Fix maps" (contains too little information) and the PR modifies multiple official maps, it cannot be merged no matter in the end whether we allow modifying official maps or not
- CCCP84 said "Many sections have been changed in the map file". It is unclear whether your latest commit solves all unnecessary changes. Please explicitly answer that
I suggest you submit two PRs, where one PR modifies one official map only. Explicitly state the motivation (why modifying it, like what's wrong with the current map), the diff (what you have modified), and does this change bring any in-game differences than the visual


Map Name : [8] Near Ore Far


Description : I'll clear the remaining gems at the top near spot 1 since its hard to place a building there