Main Menu Video Background by Mentalleger · Pull Request #838 · CnCNet/xna-cncnet-client

Mentalleger · 2025-10-02T13:16:08Z

Added a new video background to the main menu, developed mostly for RA2 YR

github-actions · 2025-10-02T13:36:58Z

Nightly build for this pull request:

artifacts.zip
This comment is automatic and is meant to allow guests to get latest automatic builds without registering. It is updated on every successful build.

MahBoiDeveloper · 2025-10-02T13:40:01Z

 using DTAClient.DXGUI.Multiplayer.CnCNet;
 using DTAClient.DXGUI.Multiplayer.GameLobby;
 using DTAClient.Online;
+//using DTAConfig;


Remove this line, DTAConfig project has been removed from client's code base.

MahBoiDeveloper · 2025-10-02T18:44:38Z

+namespace DXMainClient.Domain
+{
+    public class VideoBackground : IDisposable


This is a generic UI class. Move it to the ClientGUI please.

removed a commented code (" using DTAConfig; ") moved VideoBackground.cs from Domain into DXGUI\Generic

SadPencil · 2025-10-04T05:35:50Z

Remaining works:

We have macOS/Linux users. If the codes do not contains such a support, please make sure the client shows the static image as if this PR were not merged. Make sure the client does not crash when the video player fails (I don't know).
We have a common way to read "RA2MD.ini", which is defined in UserINISettings class

Copilot

Pull request overview

This PR adds video background support to the main menu, primarily developed for Red Alert 2: Yuri's Revenge. The implementation uses LibVLC to play MP4 video files as an animated background, falling back to the static PNG background if the video file is not found.

Key changes:

Integrated LibVLCSharp and VideoLAN.LibVLC.Windows packages for video playback
Created a new VideoBackground class to handle video decoding and texture updates
Modified MainMenu to optionally load and display video backgrounds

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 15 comments.

Show a summary per file

File	Description
Directory.Packages.props	Added LibVLCSharp (3.9.4) and VideoLAN.LibVLC.Windows (3.0.21) package references
DXMainClient/DXMainClient.csproj	Added VideoLAN.LibVLC.Windows package reference to the main client project
ClientGUI/ClientGUI.csproj	Added LibVLCSharp package reference to the GUI library
ClientGUI/VideoBackground.cs	New class implementing video playback using LibVLC with XNA/MonoGame texture integration
DXMainClient/DXGUI/Generic/MainMenu.cs	Integrated video background loading with fallback to static image, added LibVLC cleanup on exit

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-30T12:56:37Z

+            _texture = new Texture2D(graphicsDevice, (int)_videoWidth, (int)_videoHeight, false, SurfaceFormat.Color);
+
+            _mediaPlayer.SetVideoCallbacks(Lock, Unlock, Display);
+            _mediaPlayer.SetVideoFormat("RGBA", (uint)_videoWidth, (uint)_videoHeight, (uint)_videoWidth * 4); // do not use RV32, use RGBA instead, else the color will be messed up as if it were blue


[nitpick] The comment contains grammatical errors and unclear explanation. Consider rephrasing to: "// Use RGBA format instead of RV32 to ensure correct color channel mapping"

Suggested change

_mediaPlayer.SetVideoFormat("RGBA", (uint)_videoWidth, (uint)_videoHeight, (uint)_videoWidth * 4); // do not use RV32, use RGBA instead, else the color will be messed up as if it were blue

_mediaPlayer.SetVideoFormat("RGBA", (uint)_videoWidth, (uint)_videoHeight, (uint)_videoWidth * 4); // Use RGBA format instead of RV32 to ensure correct color channel mapping

Copilot · 2025-11-30T12:56:37Z

+            _media = new Media(_libVLC, videoPath, FromType.FromPath);
+
+            // add more option if you want to edit the video via VLC
+            _media.AddOption(":scale=0.5"); // compress the video (a little help with the lower end devices.||_ ps. its a 50/50 in the lower end device)


[nitpick] The comment contains grammatical errors and is unclear. The phrase "a little help with the lower end devices.||_ ps. its a 50/50 in the lower end device" should be rephrased more professionally, e.g., "// Reduce video quality to improve performance on lower-end devices (may have variable results)"

Suggested change

_media.AddOption(":scale=0.5"); // compress the video (a little help with the lower end devices.||_ ps. its a 50/50 in the lower end device)

_media.AddOption(":scale=0.5"); // Reduce video quality to improve performance on lower-end devices (may have variable results)

Copilot · 2025-11-30T12:56:37Z

+            _media = new Media(_libVLC, videoPath, FromType.FromPath);
+
+            // add more option if you want to edit the video via VLC
+            _media.AddOption(":scale=0.5"); // compress the video (a little help with the lower end devices.||_ ps. its a 50/50 in the lower end device)


The :scale=0.5 option compresses/scales the video to 50%, but the texture buffer is allocated at full size (_videoWidth * _videoHeight * 4). This mismatch could cause rendering issues or leave parts of the texture uninitialized. Either remove the scale option or adjust the buffer and texture size accordingly.

Copilot · 2025-11-30T12:56:39Z

+        private void Display(IntPtr opaque, IntPtr picture)
+        {
+            lock (_lock)
+            {
+                _texture.SetData(_videoBuffer);
+            }


The Display callback writes to _texture from the VLC thread, but Texture2D.SetData in XNA/MonoGame is not thread-safe and should only be called from the main/game thread. This can cause crashes or rendering corruption.

Consider using a flag to indicate new data is ready and perform the SetData call from the main thread's update or draw method instead.

Good thought. I'll leave this conversation open.

Copilot · 2025-11-30T12:56:39Z

+            // add more option if you want to edit the video via VLC
+            _media.AddOption(":scale=0.5"); // compress the video (a little help with the lower end devices.||_ ps. its a 50/50 in the lower end device)
+            _media.AddOption(":no-audio"); // disables the audio
+            _media.AddOption(":input-repeat=65535"); // this means looping the video 65.535 times, its stupid but it works


[nitpick] The comment "its stupid but it works" is unprofessional and doesn't add value. Consider rephrasing to explain why this approach was chosen, e.g., ":input-repeat=65535 // Loop video continuously (maximum repeat count)"

Suggested change

_media.AddOption(":input-repeat=65535"); // this means looping the video 65.535 times, its stupid but it works

_media.AddOption(":input-repeat=65535"); // Loop video continuously (maximum repeat count supported by VLC)

Copilot · 2025-11-30T12:56:40Z

+        public VideoBackground(GraphicsDevice graphicsDevice, string videoPath, int width, int height)
+        {
+            if (_libVLC == null)
+                _libVLC = new LibVLC("--no-xlib", "--drop-late-frames", "--skip-frames");


Write to static field from instance method, property, or constructor.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Main Menu Video Background

d704034

Added a new video background to the main menu, developed mostly for RA2 YR

MahBoiDeveloper requested changes Oct 2, 2025

View reviewed changes

fixed some unorganized stuffs

3c9fecb

removed a commented code (" using DTAConfig; ") moved VideoBackground.cs from Domain into DXGUI\Generic

SadPencil force-pushed the develop branch from 47e2851 to 2597f10 Compare November 6, 2025 13:28

SadPencil force-pushed the develop branch from 9db87a8 to e0d174c Compare November 14, 2025 16:50

SadPencil added 6 commits November 30, 2025 20:13

Merge branch 'develop' into Main-Menu-Video-Background-via-VLC

9d112cc

Move VideoBackground to XNAUI and remove hardcoded behaviors

15b0caf

Sort using and remove accidently introduced line in VideoBackground

59ae5df

Update nullable programming in VideoBackground

d128ffc

Revert unnecessary changes

148e5ca

Revert unnecessary changes

694f706

SadPencil requested a review from Copilot November 30, 2025 12:52

Copilot started reviewing on behalf of SadPencil November 30, 2025 12:52 View session

Copilot finished reviewing on behalf of SadPencil November 30, 2025 12:54

Revise the comment

89d635d

Copilot AI reviewed Nov 30, 2025

View reviewed changes

SadPencil and others added 5 commits November 30, 2025 20:57

Revise the comment

095a35e

Correct the typo

267f4dd

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Revert unnecessary changes

e4cb279

Remove extra line breaks introduced by the web editor

3e6cb62

Move Lock, Unlock, Display method into lambdas

0ddaeb9

SadPencil added this to the long term milestone May 5, 2026

SadPencil force-pushed the develop branch from 4eff2ea to b5d670d Compare May 15, 2026 19:31

	_mediaPlayer.SetVideoFormat("RGBA", (uint)_videoWidth, (uint)_videoHeight, (uint)_videoWidth * 4); // do not use RV32, use RGBA instead, else the color will be messed up as if it were blue
	_mediaPlayer.SetVideoFormat("RGBA", (uint)_videoWidth, (uint)_videoHeight, (uint)_videoWidth * 4); // Use RGBA format instead of RV32 to ensure correct color channel mapping

	_media.AddOption(":scale=0.5"); // compress the video (a little help with the lower end devices.\|\|_ ps. its a 50/50 in the lower end device)
	_media.AddOption(":scale=0.5"); // Reduce video quality to improve performance on lower-end devices (may have variable results)

	_media.AddOption(":input-repeat=65535"); // this means looping the video 65.535 times, its stupid but it works
	_media.AddOption(":input-repeat=65535"); // Loop video continuously (maximum repeat count supported by VLC)

Uh oh!

Conversation

Mentalleger commented Oct 2, 2025

Uh oh!

github-actions Bot commented Oct 2, 2025

Uh oh!

MahBoiDeveloper Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

MahBoiDeveloper Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

SadPencil commented Oct 4, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Nov 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Nov 30, 2025

Choose a reason for hiding this comment

Uh oh!

SadPencil Nov 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants