Use a shorter timeout for CnCNet player count retrieval#896
Merged
Conversation
|
Nightly build for this pull request:
|
MahBoiDeveloper
approved these changes
Dec 10, 2025
Member
|
Looks fine. I question why we're using a blocking method though. Perhaps we switch to the web label #883 when it's ready. |
Member
Author
Member
|
I agree with switching to web label btw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR differs the initial GetCnCNetPlayerCount call (sync) with the upcoming GetCnCNetPlayerCount calls (async), using 1-second and 5-second timeouts respectively. Previously the timeout is 10 second (more previously it was 100 second xD), might be a little bit of long just retrieving a number and therefore unnecessary.