Add sync log uploading to mapdb#972
Draft
11EJDE11 wants to merge 3 commits into
Draft
Conversation
|
Nightly build for this pull request:
|
SadPencil
reviewed
Apr 5, 2026
|
|
||
| private static void WriteFormField(Stream stream, string boundary, string name, string value) | ||
| { | ||
| byte[] bytes = Encoding.UTF8.GetBytes( |
Member
There was a problem hiding this comment.
Note the BOM issue. Perhaps EncodingExt.UTF8NoBom
Same for other UTF8 usages
| @@ -0,0 +1,203 @@ | |||
| using System; | |||
Member
There was a problem hiding this comment.
Since this is a new .cs file I suggest adding #nullable enable
| $"Content-Type: text/plain\r\n\r\n"); | ||
| requestStream.Write(header, 0, header.Length); | ||
|
|
||
| byte[] buffer = new byte[65536]; |
| DisablePrivateMessagePopups = new BoolSetting(iniFile, MULTIPLAYER, "DisablePrivateMessagePopups", false); | ||
| AllowPrivateMessagesFromState = new IntSetting(iniFile, MULTIPLAYER, "AllowPrivateMessagesFromState", (int)AllowPrivateMessagesFromEnum.All); | ||
| EnableMapSharing = new BoolSetting(iniFile, MULTIPLAYER, "EnableMapSharing", true); | ||
| AutoUploadSyncLogs = new BoolSetting(iniFile, MULTIPLAYER, "AutoUploadSyncLogs", true); |
Member
There was a problem hiding this comment.
I don't know if we need to revise the GDPR dialog in order to make this option default
… - Replace Encoding.UTF8 with EncodingExt.UTF8NoBOM throughout - Remove unused SyncLogUploadStarted/Complete/Failed event declarations - Broaden SYNC file search pattern from SYNC{i}_*.TXT to SYNC{i}*.TXT
- Wire up sync log upload in the Ares branch of GameInProgressWindow
- Fix ComputeGameHash doc comment to describe the actual hash format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Info that gets sent:
"game_hash",
"player_name",
"sync_file_index",
"map_sha1",
"map_name",
"game_mode",
"game_slug",
Currently a draft as I need to add an endpoint to the mapdb (have this mostly working locally, just need to give it more testing and review with YD).