Few little optimisations by crafter23456 · Pull Request #365 · CobbleSword/NachoSpigot

crafter23456 · 2022-02-28T16:24:19Z

Description

Use Vanilla Minecart Speeds

Minecart is driving like it should, I didnt made any tests how far it fly etc only if it works normal

Optimize World Time Updates PaperMC/Paper@70e091b

time went normal, /time set X works. so should be fine

I bumped some dependencies and updated the velocity repo cause the link was broken. Log4j should be fixed with only the core in fact Paper did only the trove4j and log4j core in their 1.8.8 log4j bugfix.
PaperMC/Paper@2894af0#diff-9f5fad4c579c54b5c3b0080702b87b856679a932ee4338409dab8b8cebe06292R16
Besides of that I got inspired by the spigot 1.18.1 pom and changed gitdescribe to scriptus.
All builds fine. No console errors.

Checklist:

I have reviewed my code thoroughly.
I have tested my code.
My changes generate no new warnings

HowardZHY · 2022-02-28T16:57:58Z

will @crafter23456
Use Vanilla Minecart Speeds
have an influence with Train Carts pl ?

crafter23456 · 2022-02-28T16:59:19Z

will @crafter23456 Use Vanilla Minecart Speeds have an influence with Train Carts pl ?

dunno. it only changes the speed back to default when the cart is flying...

…tServer.java Co-authored-by: Elier <71361901+Elierrr@users.noreply.github.com>

Co-authored-by: Elier <71361901+Elierrr@users.noreply.github.com>

…viderServer.java Co-authored-by: Elier <71361901+Elierrr@users.noreply.github.com>

…tySign.java Co-authored-by: Elier <71361901+Elierrr@users.noreply.github.com>

HeathLoganCampbell

Personal I think this is a lot of changes in one pull request which makes things really messy, I would suggest breaking them up especially since dep bumping can be high risk

HeathLoganCampbell · 2022-02-28T23:27:23Z

-        <dependency>
-            <groupId>org.apache.logging.log4j</groupId>
-            <artifactId>log4j-iostreams</artifactId>
-            <version>2.17.1</version>


Is it safe to remove these?

I would say. Paper only use the log4j core and the other thing I don't remember currently but we have that too. And my anticheat has a fix for log4j which only activates if the server didn't done it before. Isn't a 100% trust but if paper do it, I guess

Even though it would be safe, I don't think it's recommended to combine multiple versions of a library.
IMO, this should be reverted. There's no reason for this.

Co-authored-by: Elier <71361901+Elierrr@users.noreply.github.com>

…CraftBlockState.java Co-authored-by: Elier <71361901+Elierrr@users.noreply.github.com>

Update pom.xml

crafter23456 · 2022-03-02T20:46:53Z

okay thats quiet weird. on my fork it builds, and here not. in fact that it builded here until we commited entityhuman out...

ghost · 2022-03-02T20:48:27Z

okay thats quiet weird. on my fork it builds, and here not. in fact that it builded here until we commited entityhuman out...

That’s because it can’t find bungeecord-chat and you have it cached

Sculas · 2022-03-02T20:49:33Z

Did you add that dependency? If not, we might have a problem again. Need to look into a Maven repository sometime for this.

crafter23456 · 2022-03-02T20:53:30Z

okay thats quiet weird. on my fork it builds, and here not. in fact that it builded here until we commited entityhuman out...

That’s because it can’t find bungeecord-chat and you have it cached

no i mean on my repo on GH with the same GH actions xd on my server yes thats cached

Did you add that dependency? If not, we might have a problem again. Need to look into a Maven repository sometime for this.

I changed the velocity repo link cause it was outdated and the normal build script but it builded here already until we added a commit which isnt related if the api doesnt get found

ghost · 2022-03-02T20:55:30Z

Did you add that dependency? If not, we might have a problem again. Need to look into a Maven repository sometime for this.

It’s caused by the removal of the sonatype parent, I have a fix in crafter23456#3

Patch 1

crafter23456 · 2022-03-02T21:04:27Z

there still open conversations from heath

Sculas · 2022-03-02T21:06:09Z

-        <dependency>
-            <groupId>org.apache.logging.log4j</groupId>
-            <artifactId>log4j-iostreams</artifactId>
-            <version>2.17.1</version>


Even though it would be safe, I don't think it's recommended to combine multiple versions of a library.
IMO, this should be reverted. There's no reason for this.

moving it to another PR

sadcenter · 2022-03-03T15:46:06Z

@Lucaskyy I personally like the time per player feature, and it has no performance impact so yea. I used time per player and it worked on nacho

crafter23456 · 2022-03-04T15:48:16Z

Personal I think this is a lot of changes in one pull request which makes things really messy, I would suggest breaking them up especially since dep bumping can be high risk

i split the boat thing into another PR. so now its not that much

HowardZHY · 2022-03-26T09:10:50Z

Is this getBlock could cause NoCom exploit server crash? At 2022-03-26 16:22:23, "Heath L Campbell" ***@***.***> wrote: @HeathLoganCampbell commented on this pull request. In NachoSpigot-Server/src/main/java/org/bukkit/craftbukkit/block/CraftBlockState.java:

@@ -132,7 +129,7 @@ public int getTypeId() {

} public byte getLightLevel() { - return light; + return getBlock().getLightLevel(); Like this might be good if CraftBlockState gets generated everytime getblock is created and getLightLevel isn't hit alot — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: ***@***.***>

crafter23456 · 2022-03-29T16:09:18Z

@HeathLoganCampbell I removed the new world time patch. Is there anything else I missed?

crafter23456 added 3 commits February 28, 2022 16:54

remove unneeded boat interaction event

2c2e703

Use Vanilla Minecart Speeds + comment fixes

36fb0ae

few things

beb221c

ghost suggested changes Feb 28, 2022

View reviewed changes

crafter23456 and others added 3 commits March 1, 2022 00:31

Update NachoSpigot-Server/src/main/java/net/minecraft/server/Minecraf…

c6d2600

…tServer.java Co-authored-by: Elier <71361901+Elierrr@users.noreply.github.com>

Update NachoSpigot-Server/pom.xml

636e7b6

Co-authored-by: Elier <71361901+Elierrr@users.noreply.github.com>

Update NachoSpigot-Server/src/main/java/net/minecraft/server/ChunkPro…

dc6731b

…viderServer.java Co-authored-by: Elier <71361901+Elierrr@users.noreply.github.com>

ghost reviewed Feb 28, 2022

View reviewed changes

Comment thread NachoSpigot-Server/src/main/java/net/minecraft/server/TileEntitySign.java

Update NachoSpigot-Server/src/main/java/net/minecraft/server/TileEnti…

4ff4644

…tySign.java Co-authored-by: Elier <71361901+Elierrr@users.noreply.github.com>

HeathLoganCampbell suggested changes Feb 28, 2022

View reviewed changes

crafter23456 and others added 7 commits March 1, 2022 00:38

Update pom.xml

4f0f4af

Co-authored-by: Elier <71361901+Elierrr@users.noreply.github.com>

Update pom.xml

961820d

Co-authored-by: Elier <71361901+Elierrr@users.noreply.github.com>

Update NachoSpigot-Server/src/main/java/org/bukkit/craftbukkit/block/…

38cbe6e

…CraftBlockState.java Co-authored-by: Elier <71361901+Elierrr@users.noreply.github.com>

Update NachoSpigot-Server/src/main/java/org/bukkit/craftbukkit/block/…

e2cda97

…CraftBlockState.java Co-authored-by: Elier <71361901+Elierrr@users.noreply.github.com>

Update NachoSpigot-Server/src/main/java/org/bukkit/craftbukkit/block/…

392058d

…CraftBlockState.java Co-authored-by: Elier <71361901+Elierrr@users.noreply.github.com>

Update NachoSpigot-Server/src/main/java/org/bukkit/craftbukkit/block/…

c58cf15

…CraftBlockState.java Co-authored-by: Elier <71361901+Elierrr@users.noreply.github.com>

fix compiling

7c8bf14

crafter23456 force-pushed the test branch from aa0d942 to 7c8bf14 Compare March 1, 2022 10:17

Elier and others added 3 commits March 2, 2022 15:06

Update pom.xml

23c4925

Merge branch 'CobbleSword:master' into patch-1

ef37ae2

Merge pull request #2 from Elierrr/patch-1

c97f630

Update pom.xml

Update pom.xml

7864b34

Update pom.xml

1e23b17

Merge pull request #3 from Elierrr/patch-1

25937e7

Patch 1

ghost approved these changes Mar 2, 2022

View reviewed changes

Sculas reviewed Mar 2, 2022

View reviewed changes

crafter23456 added 3 commits March 2, 2022 22:25

revert "unneeded boat event trigger"

85145b4

moving it to another PR

missed that

41fdd06

Update README.md

209f4fd

Sculas requested a review from HeathLoganCampbell March 12, 2022 18:00

HeathLoganCampbell suggested changes Mar 26, 2022

View reviewed changes

Comment thread NachoSpigot-Server/src/main/java/net/minecraft/server/MinecraftServer.java

Comment thread NachoSpigot-Server/src/main/java/net/minecraft/server/TileEntitySign.java Outdated

Comment thread NachoSpigot-Server/src/main/java/org/bukkit/craftbukkit/block/CraftBlockState.java Outdated

revert things, update things

b1f7f2a

ghost mentioned this pull request Apr 7, 2022

FEATURE REQUEST: Add NachoSpigot support retrooper/packetevents#307

Closed

update paper repository link

3b418fc

Conversation

crafter23456 commented Feb 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist:

Uh oh!

HowardZHY commented Feb 28, 2022

Uh oh!

crafter23456 commented Feb 28, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HeathLoganCampbell left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

HeathLoganCampbell Feb 28, 2022

Choose a reason for hiding this comment

Uh oh!

crafter23456 Feb 28, 2022

Choose a reason for hiding this comment

Uh oh!

Sculas Mar 2, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

crafter23456 commented Mar 2, 2022

Uh oh!

ghost commented Mar 2, 2022

Uh oh!

Sculas commented Mar 2, 2022

Uh oh!

crafter23456 commented Mar 2, 2022

Uh oh!

ghost commented Mar 2, 2022 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

crafter23456 commented Mar 2, 2022

Uh oh!

Sculas Mar 2, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sadcenter commented Mar 3, 2022

Uh oh!

crafter23456 commented Mar 4, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HowardZHY commented Mar 26, 2022 via email

Uh oh!

crafter23456 commented Mar 29, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

crafter23456 commented Feb 28, 2022 •

edited

Loading

ghost commented Mar 2, 2022 •

edited by ghost

Loading