--wip-- [skip ci] test

Author: GuillaumeLagrange

packages/playwright/src/index.ts

@@ -9,6 +9,8 @@ import {
   type Benchmark,
   type BenchmarkStats,
 } from "@codspeed/core";
+import { createRequire } from "node:module";
+import { pathToFileURL } from "node:url";
 import { _electron as electron } from "playwright";
 import type { ElectronApplication, Page } from "playwright-core";
 
@@ -52,20 +54,18 @@ export interface BenchOptions {
    */
   appPath: string;
   /**
-   * Additional CLI flags forwarded to Electron.
+   * CLI flags forwarded to Electron.
    */
   electronArgs?: string[];
   /**
    * Working directory for the Electron process. Defaults to `process.cwd()`.
    */
   cwd?: string;
   /**
-   * Absolute path to the Electron executable. When omitted, Playwright resolves
-   * it via `require("electron")`. Set this when running under package managers
-   * (e.g. pnpm) where Playwright cannot resolve `electron` from its own
-   * directory.
+   * Absolute path to the Electron executable. When omitted, it is resolved from
+   * the `electron` package in `cwd`. Set this only to override that default.
    */
-  executablePath?: string;
+  electronExecutablePath?: string;
   /**
    * Run before each round, after the window opens. Use it to bring the app to
    * a steady state (initial render done, data loaded, …). Not measured.
@@ -106,15 +106,32 @@ function resolveRounds(optionRounds: number | undefined): number {
   return n;
 }
 
+/**
+ * Resolve the path to the Electron binary.
+ *
+ * Playwright resolves Electron via `require("electron/index.js")` from inside
+ * its own package directory. Under isolated installs (e.g. pnpm), Playwright
+ * cannot see the project's `electron` dependency and bails out with
+ * "Electron executablePath not found!". We resolve it ourselves from the
+ * benchmark's working directory, where `electron` is a real dependency.
+ */
+function resolveElectronExecutable(cwd: string): string {
+  const require = createRequire(pathToFileURL(`${cwd}/`));
+  // `electron`'s main module exports the absolute path to its binary.
+  return require("electron") as string;
+}
+
 async function launchApp(options: BenchOptions): Promise<ElectronApplication> {
+  const cwd = options.cwd ?? process.cwd();
   return electron.launch({
     args: [
       options.appPath,
       ...(options.electronArgs ?? []),
       `--js-flags=${DEFAULT_PROFILING_JS_FLAGS}`,
     ],
-    cwd: options.cwd ?? process.cwd(),
-    executablePath: options.executablePath,
+    cwd,
+    executablePath:
+      options.electronExecutablePath ?? resolveElectronExecutable(cwd),
   });
 }