feat: to fixup tinybench marker clean up

Author: GuillaumeLagrange

packages/tinybench-plugin/src/analysis.ts

@@ -40,7 +40,17 @@ class AnalysisBenchRunner extends BaseBenchRunner {
     await mongoMeasurement.start(uri);
 
     global.gc?.();
-    await this.wrapWithInstrumentHooksAsync(wrapWithRootFrame(fn), uri);
+    const rootFrame = wrapWithRootFrame(fn);
+    InstrumentHooks.startBenchmark();
+    const runStart = InstrumentHooks.currentTimestamp();
+    try {
+      await rootFrame();
+    } finally {
+      const runEnd = InstrumentHooks.currentTimestamp();
+      InstrumentHooks.stopBenchmark();
+      InstrumentHooks.setExecutedBenchmark(process.pid, uri);
+      this.sendBenchmarkMarkers(runStart, runEnd);
+    }
 
     await mongoMeasurement.stop(uri);
     await fnOpts?.afterEach?.call(task, "run");
@@ -55,7 +65,17 @@ class AnalysisBenchRunner extends BaseBenchRunner {
     fnOpts?.beforeAll?.call(task, "run");
     fnOpts?.beforeEach?.call(task, "run");
 
-    this.wrapWithInstrumentHooks(wrapWithRootFrameSync(fn), uri);
+    const rootFrame = wrapWithRootFrameSync(fn);
+    InstrumentHooks.startBenchmark();
+    const runStart = InstrumentHooks.currentTimestamp();
+    try {
+      rootFrame();
+    } finally {
+      const runEnd = InstrumentHooks.currentTimestamp();
+      InstrumentHooks.stopBenchmark();
+      InstrumentHooks.setExecutedBenchmark(process.pid, uri);
+      this.sendBenchmarkMarkers(runStart, runEnd);
+    }
 
     fnOpts?.afterEach?.call(task, "run");
     fnOpts?.afterAll?.call(task, "run");

packages/tinybench-plugin/src/shared.ts

@@ -1,12 +1,11 @@
 import {
-  getInstrumentMode,
   InstrumentHooks,
   MARKER_TYPE_BENCHMARK_END,
   MARKER_TYPE_BENCHMARK_START,
   setupCore,
   teardownCore,
 } from "@codspeed/core";
-import { Bench, Fn, Task } from "tinybench";
+import { Bench, Task } from "tinybench";
 import { CapturedTaskData, getTaskData } from "./taskData";
 import { getTaskUri } from "./uri";
 
@@ -56,57 +55,12 @@ export abstract class BaseBenchRunner {
     return this.bench.tasks;
   }
 
-  protected wrapWithInstrumentHooks<T>(fn: () => T, uri: string): T {
-    const runStart = this.openInstrumentWindow();
-    try {
-      return fn();
-    } finally {
-      this.closeInstrumentWindow(uri, runStart);
-    }
-  }
-
-  protected async wrapWithInstrumentHooksAsync(
-    fn: Fn,
-    uri: string,
-  ): Promise<unknown> {
-    const runStart = this.openInstrumentWindow();
-    try {
-      return await fn();
-    } finally {
-      this.closeInstrumentWindow(uri, runStart);
-    }
-  }
-
-  protected openInstrumentWindow(): bigint {
-    InstrumentHooks.startBenchmark();
-    return InstrumentHooks.currentTimestamp();
-  }
-
-  protected closeInstrumentWindow(uri: string, runStart: bigint): void {
-    const runEnd = InstrumentHooks.currentTimestamp();
-    InstrumentHooks.stopBenchmark();
-    InstrumentHooks.setExecutedBenchmark(process.pid, uri);
-    this.sendBenchmarkMarkers(runStart, runEnd);
-  }
-
   protected abstract getModeName(): string;
   protected abstract runTaskAsync(task: Task, uri: string): Promise<void>;
   protected abstract runTaskSync(task: Task, uri: string): void;
   protected abstract finalizeAsyncRun(): Task[];
   protected abstract finalizeSyncRun(): Task[];
 
-  private sendBenchmarkMarkers(runStart: bigint, runEnd: bigint): void {
-    if (getInstrumentMode() !== "walltime") {
-      return;
-    }
-    InstrumentHooks.addMarker(
-      process.pid,
-      MARKER_TYPE_BENCHMARK_START,
-      runStart,
-    );
-    InstrumentHooks.addMarker(process.pid, MARKER_TYPE_BENCHMARK_END, runEnd);
-  }
-
   public setupBenchMethods(): void {
     this.bench.run = async () => {
       this.setupBenchRun();
@@ -130,4 +84,13 @@ export abstract class BaseBenchRunner {
       return this.finalizeSyncRun();
     };
   }
+
+  protected sendBenchmarkMarkers(runStart: bigint, runEnd: bigint): void {
+    InstrumentHooks.addMarker(
+      process.pid,
+      MARKER_TYPE_BENCHMARK_START,
+      runStart,
+    );
+    InstrumentHooks.addMarker(process.pid, MARKER_TYPE_BENCHMARK_END, runEnd);
+  }
 }

packages/tinybench-plugin/src/walltime.ts

@@ -1,5 +1,6 @@
 import {
   calculateQuantiles,
+  InstrumentHooks,
   mongoMeasurement,
   msToNs,
   msToS,
@@ -54,14 +55,24 @@ class WalltimeBenchRunner extends BaseBenchRunner {
     opts.setup = (task, mode) => {
       const setupResult = userSetup(task, mode);
       if (mode === "run") {
-        this.runStart = this.openInstrumentWindow();
+        InstrumentHooks.startBenchmark();
+        this.runStart = InstrumentHooks.currentTimestamp();
       }
       return setupResult;
     };
 
     opts.teardown = (task, mode) => {
       if (mode === "run" && task) {
-        this.closeInstrumentWindow(this.getTaskUri(task), this.runStart!);
+        const runEnd = InstrumentHooks.currentTimestamp();
+        InstrumentHooks.stopBenchmark();
+        InstrumentHooks.setExecutedBenchmark(
+          process.pid,
+          this.getTaskUri(task),
+        );
+        if (this.runStart !== null) {
+          this.sendBenchmarkMarkers(this.runStart, runEnd);
+        }
+
         this.runStart = null;
       }
       return userTeardown(task, mode);