Skip to content

Commit c88994c

Browse files
fix: have node output perf maps when not parsing V8 inlining logs
1 parent 36834e8 commit c88994c

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

.github/workflows/codspeed.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,6 @@ jobs:
8686
CODSPEED_WALLTIME_PROFILER: samply
8787
with:
8888
mode: walltime
89-
# TODO: Remove this once runner is released
90-
runner-version: v4.17.7-alpha.2
9189
run: |
9290
pnpm turbo run bench --filter=@codspeed/tinybench-plugin
9391
pnpm turbo run bench --filter=@codspeed/vitest-plugin

packages/core/src/introspection.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ export const getV8Flags = () => {
4040
case "walltime": {
4141
// Emit the V8 jitdump
4242
flags.push("--perf-prof");
43+
4344
const v8LogDir = process.env.CODSPEED_V8_LOG;
4445
if (v8LogDir) {
4546
flags.push(
@@ -50,6 +51,9 @@ export const getV8Flags = () => {
5051
`--logfile=${path.join(v8LogDir, V8_LOG_FILENAME_PATTERN)}`,
5152
],
5253
);
54+
} else {
55+
// Just output the perf.map
56+
flags.push("--perf-basic-prof");
5357
}
5458
}
5559
}

0 commit comments

Comments
 (0)