Skip to content

Commit 003ce2d

Browse files
committed
Fix lower bound of cc crate
Currently, the codspeed crate is declaring a dependency on cc 1.0, while using newer features. This is causing errors in minimal version checks in downstream crates. This PR dumps the cc minimal version and adds a minimal-versions CI check to enforce correct lower bounds.
1 parent 99c7b5a commit 003ce2d

3 files changed

Lines changed: 21 additions & 7 deletions

File tree

.github/workflows/ci.yml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,19 @@ jobs:
102102
- name: Check divan_compat MSRV
103103
run: cargo msrv --path crates/divan_compat verify -- cargo check --all-features --config codspeed=true
104104

105+
minimal-versions:
106+
runs-on: ubuntu-latest
107+
steps:
108+
- uses: actions/checkout@v4
109+
with:
110+
submodules: true
111+
- uses: moonrepo/setup-rust@v1
112+
env:
113+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
114+
- run: rustup toolchain install nightly --profile minimal
115+
- run: cargo +nightly update -Zminimal-versions -p codspeed --recursive
116+
- run: cargo check -p codspeed --all-features --config codspeed=true
117+
105118
tests-without-cargo-codspeed:
106119
runs-on: ubuntu-latest
107120
steps:
@@ -283,6 +296,7 @@ jobs:
283296
- tests-without-cargo-codspeed
284297
- test-cargo-codspeed
285298
- msrv-check
299+
- minimal-versions
286300
- analysis-integration-test
287301
- walltime-integration-test
288302
- walltime-macos-test

Cargo.lock

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

crates/codspeed/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,4 +36,4 @@ harness = false
3636
tempfile = { workspace = true }
3737

3838
[build-dependencies]
39-
cc = "1.0"
39+
cc = "1.2.40"

0 commit comments

Comments
 (0)