feat(cargo-codspeed): handle rustflags from .cargo/config.toml

Author: GuillaumeLagrange

crates/cargo-codspeed/Cargo.toml

@@ -10,10 +10,10 @@ repository = "https://github.com/CodSpeedHQ/codspeed-rust"
 homepage = "https://codspeed.io"
 license = "MIT OR Apache-2.0"
 categories = [
-    "development-tools",
-    "development-tools::cargo-plugins",
-    "development-tools::profiling",
-    "development-tools::testing",
+  "development-tools",
+  "development-tools::cargo-plugins",
+  "development-tools::profiling",
+  "development-tools::testing",
 ]
 keywords = ["codspeed", "benchmark", "cargo"]
 

crates/cargo-codspeed/src/build.rs

@@ -105,30 +105,60 @@ impl BuildOptions<'_> {
         Ok(built_benches)
     }
 
+    /// Adds debug flags and codspeed compilation
+    ///
+    /// If the user has set `RUSTFLAGS`, it will append the flags to it.
+    /// Else, and if the cargo version allows it, it will set the cargo config through
+    /// `--config 'build.rustflags=[ ... ]'`
+    ///
+    /// # Why we do this
+    /// As tracked in [https://github.com/rust-lang/cargo/issues/5376], setting `RUSTFLAGS`
+    /// completely overrides rustflags from rust config
+    /// We use the cargo built-in config mechanism to set the flags if the user has not set
+    /// `RUSTFLAGS`.
+    fn add_rust_flags(&self, cargo: &mut Command, measurement_mode: MeasurementMode) {
+        let mut flags = vec![
+            // Add debug info (equivalent to -g)
+            "-Cdebuginfo=2".to_owned(),
+            // Prevent debug info stripping
+            // https://doc.rust-lang.org/cargo/reference/profiles.html#release
+            // According to cargo docs, for release profile which we default to:
+            // `strip = "none"` and `debug = false`.
+            // In practice, if we set debug info through RUSTFLAGS, cargo still strips them, most
+            // likely because debug = false in the release profile.
+            // We also need to disable stripping through rust flags.
+            "-Cstrip=none".to_owned(),
+        ];
+
+        // Add the codspeed cfg flag if instrumentation mode is enabled
+        if measurement_mode == MeasurementMode::Instrumentation {
+            flags.push("--cfg".to_owned());
+            flags.push("codspeed".to_owned());
+        }
+
+        match std::env::var("RUSTFLAGS") {
+            Result::Ok(existing_rustflags) => {
+                let flags_str = flags.join(" ");
+                cargo.env("RUSTFLAGS", format!("{existing_rustflags} {flags_str}"));
+            }
+            Err(_) => {
+                // Use --config to set rustflags
+                let config_value = format!(
+                    "build.rustflags=[{}]",
+                    flags.into_iter().map(|f| format!("\"{f}\"")).join(",")
+                );
+                cargo.arg("--config").arg(config_value);
+            }
+        }
+    }
+
     /// Generates a subcommand to build the benchmarks by invoking cargo and forwarding the filters
     /// This command explicitly ignores the `self.benches`: all benches are built
     fn build_command(&self, measurement_mode: MeasurementMode) -> Command {
         let mut cargo = Command::new("cargo");
         cargo.args(["build", "--benches"]);
 
-        let mut rust_flags = std::env::var("RUSTFLAGS").unwrap_or_else(|_| "".into());
-        // Add debug info (equivalent to -g)
-        rust_flags.push_str(" -C debuginfo=2");
-
-        // Prevent debug info stripping
-        // https://doc.rust-lang.org/cargo/reference/profiles.html#release
-        // According to cargo docs, for release profile which we default to:
-        // `strip = "none"` and `debug = false`.
-        // In practice, if we set debug info through RUSTFLAGS, cargo still strips them, most
-        // likely because debug = false in the release profile.
-        // We also need to disable stripping through rust flags.
-        rust_flags.push_str(" -C strip=none");
-
-        // Add the codspeed cfg flag if instrumentation mode is enabled
-        if measurement_mode == MeasurementMode::Instrumentation {
-            rust_flags.push_str(" --cfg codspeed");
-        }
-        cargo.env("RUSTFLAGS", rust_flags);
+        self.add_rust_flags(&mut cargo, measurement_mode);
 
         if let Some(features) = self.features {
             cargo.arg("--features").arg(features.join(","));