fixup! feat(walltime): rename CODSPEED_PERF_ENABLED to CODSPEED_PROFILER_ENABLED

Author: not-matthias

src/cli/exec/mod.rs

@@ -77,8 +77,8 @@ fn build_orchestrator_config(
         targets: vec![target],
         modes,
         instruments: Instruments { mongodb: None }, // exec doesn't support MongoDB
-        perf_unwinding_mode: args.shared.perf_run_args.perf_unwinding_mode,
-        enable_profiler: args.shared.perf_run_args.resolve_enable_profiler(),
+        perf_unwinding_mode: args.shared.profiler_run_args.perf.perf_unwinding_mode,
+        enable_profiler: args.shared.profiler_run_args.resolve_enable_profiler(),
         simulation_tool: args.shared.simulation_tool.unwrap_or_default(),
         profile_folder: args.shared.profile_folder,
         skip_upload: args.shared.skip_upload,

src/cli/run/mod.rs

@@ -48,8 +48,8 @@ pub enum MessageFormat {
 impl RunArgs {
     /// Constructs a new `RunArgs` with default values for testing purposes
     pub fn test() -> Self {
-        use super::PerfRunArgs;
         use super::experimental::ExperimentalArgs;
+        use super::{PerfRunArgs, ProfilerRunArgs};
         use crate::RunnerMode;
 
         Self {
@@ -69,10 +69,12 @@ impl RunArgs {
                 go_runner_version: None,
                 show_full_output: false,
                 base: None,
-                perf_run_args: PerfRunArgs {
+                profiler_run_args: ProfilerRunArgs {
                     enable_profiler: false,
                     enable_perf: None,
-                    perf_unwinding_mode: None,
+                    perf: PerfRunArgs {
+                        perf_unwinding_mode: None,
+                    },
                 },
                 experimental: ExperimentalArgs {
                     experimental_fair_sched: false,
@@ -112,8 +114,8 @@ fn build_orchestrator_config(
         targets,
         modes,
         instruments,
-        perf_unwinding_mode: args.shared.perf_run_args.perf_unwinding_mode,
-        enable_profiler: args.shared.perf_run_args.resolve_enable_profiler(),
+        perf_unwinding_mode: args.shared.profiler_run_args.perf.perf_unwinding_mode,
+        enable_profiler: args.shared.profiler_run_args.resolve_enable_profiler(),
         simulation_tool: args.shared.simulation_tool.unwrap_or_default(),
         profile_folder: args.shared.profile_folder,
         skip_upload: args.shared.skip_upload,

src/cli/shared.rs

@@ -109,7 +109,7 @@ pub struct ExecAndRunSharedArgs {
     pub base: Option<String>,
 
     #[command(flatten)]
-    pub perf_run_args: PerfRunArgs,
+    pub profiler_run_args: ProfilerRunArgs,
 
     #[command(flatten)]
     pub experimental: ExperimentalArgs,
@@ -151,7 +151,7 @@ pub enum UnwindingMode {
 }
 
 #[derive(Args, Debug, Clone)]
-pub struct PerfRunArgs {
+pub struct ProfilerRunArgs {
     /// Enable a profiler to collect granular performance data.
     /// This is only supported on Linux.
     #[arg(long, env = "CODSPEED_PROFILER_ENABLED", default_value_t = true)]
@@ -161,12 +161,18 @@ pub struct PerfRunArgs {
     #[arg(long, env = "CODSPEED_PERF_ENABLED", hide = true)]
     pub enable_perf: Option<bool>,
 
+    #[command(flatten)]
+    pub perf: PerfRunArgs,
+}
+
+#[derive(Args, Debug, Clone)]
+pub struct PerfRunArgs {
     /// The unwinding mode that should be used with perf to collect the call stack.
     #[arg(long, env = "CODSPEED_PERF_UNWINDING_MODE")]
     pub perf_unwinding_mode: Option<UnwindingMode>,
 }
 
-impl PerfRunArgs {
+impl ProfilerRunArgs {
     /// Resolves the effective `enable_profiler` value, honoring the deprecated
     /// `--enable-perf` / `CODSPEED_PERF_ENABLED` flag with a warning.
     pub fn resolve_enable_profiler(&self) -> bool {