Skip to content

Commit 1431b05

Browse files
committed
fixup! fix(valgrind): install libc6-dbg during valgrind setup
1 parent 2cab37a commit 1431b05

1 file changed

Lines changed: 7 additions & 9 deletions

File tree

src/executor/valgrind/setup.rs

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -193,19 +193,17 @@ pub async fn install_valgrind(
193193
let binary = get_codspeed_valgrind_binary(system_info)?;
194194
let deb_path = env::temp_dir().join("valgrind-codspeed.deb");
195195
download_pinned_file(binary, &deb_path).await?;
196-
apt::install(system_info, &[deb_path.to_str().unwrap()])?;
196+
197+
// Install libc debug symbols alongside valgrind, as GitHub runners
198+
// do not include them by default. Keeping them in the same install
199+
// call puts them under the same caching and idempotency logic.
200+
apt::install(system_info, &[deb_path.to_str().unwrap(), "libc6-dbg"])?;
197201

198202
// Return package names for caching
199-
Ok(vec!["valgrind".to_string()])
203+
Ok(vec!["valgrind".to_string(), "libc6-dbg".to_string()])
200204
},
201205
)
202-
.await?;
203-
204-
// Install libc debug symbols, as Github runners by default do not
205-
// include them. Only install for supported systems.
206-
apt::install(system_info, &["libc6-dbg"])?;
207-
208-
Ok(())
206+
.await
209207
}
210208

211209
#[cfg(test)]

0 commit comments

Comments
 (0)