Skip to content

Commit 189c8ca

Browse files
chore: turn warning about overwritten unwind_data into debug logs
Until we properly handle multiple, unwind_data over time that can be invalidated, etc, we should not alert users for this.
1 parent 5731606 commit 189c8ca

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

crates/runner-shared/src/unwind_data.rs

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,17 @@ impl UnwindData {
3535

3636
pub fn to_file<P: AsRef<std::path::Path>>(&self, path: P) -> anyhow::Result<()> {
3737
if let Ok(true) = std::fs::exists(path.as_ref()) {
38-
log::warn!(
38+
// This happens in CI for the root `systemd-run` process which execs into bash which
39+
// also execs into bash, each process reloading common libraries like `ld-linux.so`.
40+
// We detect this when we harvest unwind_data by parsing the perf data (exec-harness).
41+
// Until we properly handle the process tree and deduplicate unwind data, just debug
42+
// log here
43+
// Any relevant occurence should have other symptoms reported by users.
44+
log::debug!(
3945
"{} already exists, file will be truncated",
4046
path.as_ref().display()
4147
);
42-
log::warn!("{} {:x?}", self.path, self.avma_range);
48+
log::debug!("{} {:x?}", self.path, self.avma_range);
4349
}
4450

4551
let compat = UnwindDataCompat::V2(self.clone());

0 commit comments

Comments
 (0)