fix(walltime): ensure perf also fails when the command fails

Author: not-matthias

src/run/runner/tests.rs

@@ -285,4 +285,16 @@ fi
             .await
             .unwrap();
     }
+
+    // Ensure that commands that fail actually fail
+    #[rstest::rstest]
+    #[tokio::test]
+    async fn test_walltime_executor_fails(#[values(false, true)] enable_perf: bool) {
+        let (system_info, run_data, _temp_dir) = create_test_setup().await;
+        let (_permit, executor) = get_walltime_executor().await;
+
+        let config = walltime_config("exit 1", enable_perf);
+        let result = executor.run(&config, &system_info, &run_data, &None).await;
+        assert!(result.is_err(), "Command should fail");
+    }
 }

src/run/runner/wall_time/perf/mod.rs

@@ -150,11 +150,11 @@ impl PerfRunner {
         let perf_data_file_path = profile_folder.join(PERF_DATA_FILE_NAME);
 
         let raw_command = format!(
-            "{} | cat > {}",
+            "set -o pipefail && {} | cat > {}",
             &cmd_builder.as_command_line(),
             perf_data_file_path.to_string_lossy()
         );
-        let mut wrapped_builder = CommandBuilder::new("sh");
+        let mut wrapped_builder = CommandBuilder::new("bash");
         wrapped_builder.args(["-c", &raw_command]);
 
         // IMPORTANT: Preserve the working directory from the original command