feat(walltime): auto-install samply via upstream installer script

Author: not-matthias

src/executor/wall_time/profiler/samply/mod.rs

@@ -1,14 +1,19 @@
 //! Samply profiler integration.
 
+mod setup;
+
 use crate::executor::ExecutorConfig;
+use crate::executor::ToolStatus;
 use crate::executor::helpers::command::CommandBuilder;
 use crate::executor::shared::fifo::FifoBenchmarkData;
 use crate::executor::wall_time::profiler::Profiler;
 use crate::prelude::*;
+use crate::system::SystemInfo;
 use async_trait::async_trait;
 use runner_shared::artifacts::ArtifactExt;
 use runner_shared::artifacts::ExecutionTimestamps;
 use runner_shared::metadata::WalltimeMetadata;
+use setup::{get_samply_status, install_samply};
 use std::path::Path;
 use std::path::PathBuf;
 
@@ -32,6 +37,18 @@ impl SamplyProfiler {
 
 #[async_trait(?Send)]
 impl Profiler for SamplyProfiler {
+    fn tool_status(&self) -> Option<ToolStatus> {
+        Some(get_samply_status())
+    }
+
+    async fn setup(
+        &self,
+        _system_info: &SystemInfo,
+        _setup_cache_dir: Option<&Path>,
+    ) -> anyhow::Result<()> {
+        install_samply().await
+    }
+
     async fn wrap(
         &mut self,
         mut cmd_builder: CommandBuilder,

src/executor/wall_time/profiler/samply/setup.rs

@@ -0,0 +1,77 @@
+use crate::binary_installer::ensure_binary_installed;
+use crate::executor::{ToolInstallStatus, ToolStatus};
+use crate::prelude::*;
+use std::process::Command;
+
+pub const SAMPLY_COMMAND: &str = "samply";
+pub const SAMPLY_VERSION: &str = "0.13.1";
+
+pub fn get_samply_status() -> ToolStatus {
+    let tool_name = SAMPLY_COMMAND.to_string();
+
+    let is_available = Command::new("which")
+        .arg(SAMPLY_COMMAND)
+        .output()
+        .is_ok_and(|output| output.status.success());
+    if !is_available {
+        return ToolStatus {
+            tool_name,
+            status: ToolInstallStatus::NotInstalled,
+        };
+    }
+
+    let Ok(version_output) = Command::new(SAMPLY_COMMAND).arg("--version").output() else {
+        return ToolStatus {
+            tool_name,
+            status: ToolInstallStatus::NotInstalled,
+        };
+    };
+
+    if !version_output.status.success() {
+        return ToolStatus {
+            tool_name,
+            status: ToolInstallStatus::NotInstalled,
+        };
+    }
+
+    let version = String::from_utf8_lossy(&version_output.stdout)
+        .trim()
+        .to_string();
+
+    let expected = semver::Version::parse(SAMPLY_VERSION).unwrap();
+    if let Some(version_str) = version.split_once(' ').map(|(_, v)| v.trim()) {
+        if let Ok(installed) = semver::Version::parse(version_str) {
+            if installed < expected {
+                return ToolStatus {
+                    tool_name,
+                    status: ToolInstallStatus::IncorrectVersion {
+                        version,
+                        message: format!("version too old, expecting {SAMPLY_VERSION} or higher"),
+                    },
+                };
+            }
+            return ToolStatus {
+                tool_name,
+                status: ToolInstallStatus::Installed { version },
+            };
+        }
+    }
+
+    ToolStatus {
+        tool_name,
+        status: ToolInstallStatus::IncorrectVersion {
+            version,
+            message: "could not parse version".to_string(),
+        },
+    }
+}
+
+pub async fn install_samply() -> Result<()> {
+    let get_samply_installer_url = || {
+        format!(
+            "https://github.com/mstange/samply/releases/download/samply-v{SAMPLY_VERSION}/samply-installer.sh"
+        )
+    };
+
+    ensure_binary_installed(SAMPLY_COMMAND, SAMPLY_VERSION, get_samply_installer_url).await
+}