refactor: move the benchmark display helpers to the upload module

Author: GuillaumeLagrange

src/cli/run/helpers/mod.rs

@@ -1,4 +1,3 @@
-pub(crate) mod benchmark_display;
 mod download_file;
 mod find_repository_root;
 mod format_duration;

src/cli/run/helpers/benchmark_display.rs src/upload/benchmark_display.rssrc/cli/run/helpers/benchmark_display.rs renamed to src/upload/benchmark_display.rs

@@ -11,6 +11,9 @@ use tabled::settings::style::HorizontalLine;
 use tabled::settings::{Alignment, Color, Modify, Padding, Style};
 use tabled::{Table, Tabled};
 
+/// Changes below this threshold are displayed as "~0%" to avoid noise.
+pub(super) const CHANGE_DISPLAY_EPSILON: f64 = 0.005;
+
 fn format_with_thousands_sep(n: u64) -> String {
     let s = n.to_string();
     let mut result = String::new();
@@ -366,15 +369,15 @@ pub fn build_comparison_table(results: &[CompareRunsBenchmarkResult]) -> String
                     };
 
                     let change_str = match result.change {
+                        Some(c) if c.abs() < CHANGE_DISPLAY_EPSILON => {
+                            format!("{}", style(format!("{:.1}%", c * 100.0)).dim())
+                        }
                         Some(c) if c > 0.0 => {
-                            let pct = (c * 100.0).round();
-                            format!("{}", style(format!("+{pct}%")).red().bold())
+                            format!("{}", style(format!("+{:.1}%", c * 100.0)).green().bold())
                         }
-                        Some(c) if c < 0.0 => {
-                            let pct = (c * 100.0).round();
-                            format!("{}", style(format!("{pct}%")).green().bold())
+                        Some(c) => {
+                            format!("{}", style(format!("{:.1}%", c * 100.0)).red().bold())
                         }
-                        Some(_) => format!("{}", style("0%").dim()),
                         None => "-".to_string(),
                     };
 

src/upload/mod.rs

@@ -1,3 +1,4 @@
+mod benchmark_display;
 mod interfaces;
 pub mod poll_results;
 mod profile_archive;

src/upload/poll_results.rs

@@ -4,12 +4,12 @@ use std::time::Duration;
 use console::style;
 use tokio::time::{Instant, sleep};
 
-use crate::api_client::{
-    CodSpeedAPIClient, CompareRunsResponse, CompareRunsVars, FetchLocalRunResponse,
-    FetchLocalRunVars, RunStatus,
+use super::benchmark_display::{
+    self, build_benchmark_table, build_comparison_table, build_detailed_summary,
 };
-use crate::cli::run::helpers::benchmark_display::{
-    build_benchmark_table, build_comparison_table, build_detailed_summary,
+use crate::api_client::{
+    CodSpeedAPIClient, CompareRunsOutcome, CompareRunsResponse, CompareRunsVars,
+    FetchLocalRunResponse, FetchLocalRunVars, RunStatus,
 };
 use crate::local_logger::{start_spinner, stop_spinner};
 use crate::prelude::*;