fix: only hide curser after clap is done parsing cli args

Clap exits the process directly, disregarding the drop impl of other
structs, when invoked with --help for example.

The other implementation solution would be to rely on a libc unsafe hook
to execute code no matter what at process exit, which is a bit overkill
for our usecase here.

Author: GuillaumeLagrange

src/cli/mod.rs

@@ -15,14 +15,35 @@ use std::path::PathBuf;
 use crate::{
     api_client::CodSpeedAPIClient,
     config::CodSpeedConfig,
-    local_logger::{CODSPEED_U8_COLOR_CODE, init_local_logger},
+    local_logger::{CODSPEED_U8_COLOR_CODE, IS_TTY, init_local_logger},
     prelude::*,
     project_config::DiscoveredProjectConfig,
 };
 use clap::{
     Parser, Subcommand,
     builder::{Styles, styling},
 };
+use console::Term;
+
+/// Guard that hides the terminal cursor on creation and restores it on drop.
+struct CursorGuard;
+
+impl CursorGuard {
+    fn new() -> Self {
+        if *IS_TTY {
+            let _ = Term::stderr().hide_cursor();
+        }
+        Self
+    }
+}
+
+impl Drop for CursorGuard {
+    fn drop(&mut self) {
+        if *IS_TTY {
+            let _ = Term::stderr().show_cursor();
+        }
+    }
+}
 
 fn create_styles() -> Styles {
     styling::Styles::styled()
@@ -99,6 +120,8 @@ enum Commands {
 
 pub async fn run() -> Result<()> {
     let cli = Cli::parse();
+    // Important: keep this after the Cli::parse() because the function can exit the process by itself, skipping the drop of the CursorGuard
+    let _cursor_guard = CursorGuard::new();
     let codspeed_config =
         CodSpeedConfig::load_with_override(cli.config_name.as_deref(), cli.oauth_token.as_deref())?;
     let api_client = CodSpeedAPIClient::try_from((&cli, &codspeed_config))?;

src/main.rs

@@ -1,26 +1,9 @@
 use codspeed_runner::{clean_logger, cli};
-use console::{Term, style};
+use console::style;
 use log::log_enabled;
 
-struct HiddenCursor(Term);
-
-impl HiddenCursor {
-    fn new() -> Self {
-        let term = Term::stderr();
-        let _ = term.hide_cursor();
-        Self(term)
-    }
-}
-
-impl Drop for HiddenCursor {
-    fn drop(&mut self) {
-        let _ = self.0.show_cursor();
-    }
-}
-
 #[tokio::main(flavor = "current_thread")]
 async fn main() {
-    let _cursor = HiddenCursor::new();
     let res = cli::run().await;
     if let Err(err) = res {
         // Show the primary error