feat: remove nerd fonts and centralize icon definition

Author: GuillaumeLagrange

Cargo.lock

@@ -84,6 +84,7 @@ test-with = { version = "0.15", default-features = false, features = [] }
 rstest = { version = "0.25.0", default-features = false }
 rstest_reuse = "0.7.0"
 shell-quote = "0.7.2"
+strum = { version = "0.28.0", features = ["derive"] }
 
 [workspace]
 members = [

Cargo.toml

@@ -1,6 +1,7 @@
 use crate::api_client::FetchLocalRunBenchmarkResult;
 use crate::cli::run::helpers;
 use crate::executor::ExecutorName;
+use crate::local_logger::icons::Icon;
 use console::style;
 use std::collections::HashMap;
 use tabled::settings::object::{Columns, Rows};
@@ -87,9 +88,14 @@ struct MemoryRow {
     alloc_calls: String,
 }
 
-fn build_table_with_style<T: Tabled>(rows: &[T], instrument: &str, icon: &str) -> String {
+fn build_table_with_style<T: Tabled>(rows: &[T], instrument: &str, icon: Icon) -> String {
     // Line after panel header: use ┬ to connect with columns below
-    let header_line = HorizontalLine::full('─', '┬', '├', '┤');
+    let header_line = HorizontalLine::full(
+        Icon::BoxHorizontal.as_char(),
+        Icon::BoxTDown.as_char(),
+        Icon::BoxTRight.as_char(),
+        Icon::BoxTLeft.as_char(),
+    );
     // Line after column headers: keep intersection
     let column_line = HorizontalLine::inherit(Style::modern());
 
@@ -104,7 +110,7 @@ fn build_table_with_style<T: Tabled>(rows: &[T], instrument: &str, icon: &str) -
         .with(
             Style::rounded()
                 .remove_horizontals()
-                .intersection_top('─')
+                .intersection_top(Icon::BoxHorizontal.as_char())
                 .horizontals([(1, header_line), (2, column_line)]),
         )
         .with(Modify::new(Rows::first()).with(Alignment::center()))

src/cli/run/helpers/benchmark_display.rs

@@ -1,6 +1,7 @@
 use crate::VERSION;
 use crate::executor::config::SimulationTool;
 use crate::local_logger::CODSPEED_U8_COLOR_CODE;
+use crate::local_logger::icons::Icon;
 use crate::prelude::*;
 use crate::run_environment::interfaces::RepositoryProvider;
 use crate::runner_mode::{RunnerMode, load_shell_session_mode};
@@ -19,7 +20,7 @@ pub(crate) fn show_banner() {
 
     let version_tag = style(format!("v{VERSION}")).bold();
     let url = style("codspeed.io").color256(CODSPEED_U8_COLOR_CODE);
-    let separator = style("─".repeat(52)).dim();
+    let separator = style(Icon::Separator.to_string().repeat(52)).dim();
 
     eprintln!();
     eprintln!("{}", style(logo).color256(CODSPEED_U8_COLOR_CODE).bold());

src/cli/shared.rs

@@ -1,3 +1,4 @@
+use crate::local_logger::icons::Icon;
 use serde::{Deserialize, Serialize};
 use std::fmt;
 
@@ -29,12 +30,12 @@ impl ExecutorName {
         }
     }
 
-    /// Nerd Font icon for this executor.
-    pub fn icon(&self) -> &'static str {
+    /// Icon for this executor.
+    pub fn icon(&self) -> Icon {
         match self {
-            ExecutorName::Valgrind => "\u{f4bc}",
-            ExecutorName::WallTime => "\u{f520}",
-            ExecutorName::Memory => "\u{efc5}",
+            ExecutorName::Valgrind => Icon::ExecutorValgrind,
+            ExecutorName::WallTime => Icon::ExecutorWallTime,
+            ExecutorName::Memory => Icon::ExecutorMemory,
         }
     }
 }

src/executor/interfaces.rs

@@ -0,0 +1,120 @@
+use std::fmt;
+
+#[derive(Debug)]
+#[cfg_attr(test, derive(strum::EnumIter))]
+pub enum Icon {
+    // Log level prefixes
+    /// Group header prefix (›)
+    GroupArrow,
+    /// Task completion checkmark (✓)
+    Checkmark,
+    /// Error indicator (✗)
+    Error,
+    /// Warning indicator (⚠)
+    Warning,
+    /// Debug bullet point (·)
+    Bullet,
+
+    // Impact / result indicators
+    /// Impact improved / up arrow (↑)
+    ImpactUp,
+    /// Impact regressed / down arrow (↓)
+    ImpactDown,
+    /// Impact neutral / filled circle (●)
+    ImpactNeutral,
+    /// No impact data / empty circle (○)
+    ImpactNoData,
+
+    // Executor icons
+    /// CPU simulation executor (⚙)
+    ExecutorValgrind,
+    /// Walltime executor (⏱)
+    ExecutorWallTime,
+    /// Memory executor (▤)
+    ExecutorMemory,
+
+    // Box-drawing (used by rolling buffer)
+    /// Top-left arc corner (╭)
+    BoxTopLeft,
+    /// Top-right arc corner (╮)
+    BoxTopRight,
+    /// Bottom-left arc corner (╰)
+    BoxBottomLeft,
+    /// Bottom-right arc corner (╯)
+    BoxBottomRight,
+    /// Horizontal line (─)
+    BoxHorizontal,
+    /// Vertical line (│)
+    BoxVertical,
+    /// T-junction pointing down (┬)
+    BoxTDown,
+    /// T-junction pointing right (├)
+    BoxTRight,
+    /// T-junction pointing left (┤)
+    BoxTLeft,
+
+    // Miscellaneous
+    /// Horizontal separator line character (─), same glyph as BoxHorizontal
+    Separator,
+    /// Truncation ellipsis (…)
+    Ellipsis,
+}
+
+impl Icon {
+    /// Return the icon as a `char`. Panics if the icon's string is not a single character
+    /// (all current icons are single codepoints, so this is always safe).
+    pub fn as_char(&self) -> char {
+        self.to_string()
+            .chars()
+            .next()
+            .expect("icon must be a single character")
+    }
+}
+
+impl fmt::Display for Icon {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        let ch = match self {
+            Icon::GroupArrow => "\u{203a}",       // ›
+            Icon::Checkmark => "\u{2713}",        // ✓
+            Icon::Error => "\u{2717}",            // ✗
+            Icon::Warning => "\u{26a0}",          // ⚠
+            Icon::Bullet => "\u{00b7}",           // ·
+            Icon::ImpactUp => "\u{2191}",         // ↑
+            Icon::ImpactDown => "\u{2193}",       // ↓
+            Icon::ImpactNeutral => "\u{25cf}",    // ●
+            Icon::ImpactNoData => "\u{25cb}",     // ○
+            Icon::ExecutorValgrind => "\u{2699}", // ⚙
+            Icon::ExecutorWallTime => "\u{23f1}", // ⏱
+            Icon::ExecutorMemory => "\u{25a4}",   // ▤
+            Icon::BoxTopLeft => "\u{256d}",       // ╭
+            Icon::BoxTopRight => "\u{256e}",      // ╮
+            Icon::BoxBottomLeft => "\u{2570}",    // ╰
+            Icon::BoxBottomRight => "\u{256f}",   // ╯
+            Icon::BoxHorizontal => "\u{2500}",    // ─
+            Icon::BoxVertical => "\u{2502}",      // │
+            Icon::BoxTDown => "\u{252c}",         // ┬
+            Icon::BoxTRight => "\u{251c}",        // ├
+            Icon::BoxTLeft => "\u{2524}",         // ┤
+            Icon::Separator => "\u{2500}",        // ─
+            Icon::Ellipsis => "\u{2026}",         // …
+        };
+        f.write_str(ch)
+    }
+}
+
+#[cfg(test)]
+mod tests {
+    use strum::IntoEnumIterator;
+
+    use super::*;
+
+    #[test]
+    fn test_icon_rendering() {
+        let rendered = Icon::iter()
+            .map(|icon| format!("{icon:?}: {icon}"))
+            .collect::<Vec<_>>()
+            .join("\n");
+
+        insta::assert_snapshot!(rendered);
+    }
+}

src/local_logger/icons.rs

@@ -1,3 +1,4 @@
+pub mod icons;
 pub mod rolling_buffer;
 
 use std::{
@@ -15,6 +16,7 @@ use std::io::Write;
 use std::sync::LazyLock;
 
 use crate::logger::{GroupEvent, JsonEvent, get_group_event, get_json_event};
+use icons::Icon;
 
 pub const CODSPEED_U8_COLOR_CODE: u8 = 208; // #FF8700
 
@@ -167,7 +169,9 @@ impl Log for LocalLogger {
 
 /// Format a group header with styled prefix
 fn format_group_header(name: &str) -> String {
-    let prefix = style("\u{f0da}").color256(CODSPEED_U8_COLOR_CODE).bold();
+    let prefix = style(Icon::GroupArrow.to_string())
+        .color256(CODSPEED_U8_COLOR_CODE)
+        .bold();
     let title = style(name).bold();
     format!("{prefix} {title}")
 }
@@ -179,7 +183,11 @@ pub(crate) fn format_checkmark(label: &str, dim: bool) -> String {
     } else {
         label.to_string()
     };
-    format!("  {}  {}", style("\u{f00c}").green().bold(), label)
+    format!(
+        "  {}  {}",
+        style(Icon::Checkmark.to_string()).green().bold(),
+        label
+    )
 }
 
 /// Format elapsed duration in a compact human-readable way
@@ -229,13 +237,13 @@ fn print_record(record: &log::Record) {
 fn format_log(level: log::Level, message: &str, target: &str) -> String {
     match level {
         log::Level::Error => {
-            let prefix = style("\u{f00d}").red().bold();
+            let prefix = style(Icon::Error.to_string()).red().bold();
             let msg = indent_lines(message, "    ");
             let msg = Style::new().red().apply_to(msg);
             format!("  {prefix} {msg}")
         }
         log::Level::Warn => {
-            let prefix = style("\u{f071}").yellow();
+            let prefix = style(Icon::Warning.to_string()).yellow();
             let msg = indent_lines(message, "    ");
             let msg = Style::new().yellow().apply_to(msg);
             format!("  {prefix} {msg}")
@@ -246,7 +254,7 @@ fn format_log(level: log::Level, message: &str, target: &str) -> String {
             format!("  {msg}")
         }
         log::Level::Debug => {
-            let prefix = style("\u{00B7}").dim();
+            let prefix = style(Icon::Bullet.to_string()).dim();
             let msg = indent_lines(message, "    ");
             let msg = Style::new().blue().dim().apply_to(msg);
             format!("  {prefix} {msg}")

src/local_logger/mod.rs

@@ -5,6 +5,7 @@ use std::time::{Duration, Instant};
 
 use super::{
     CODSPEED_U8_COLOR_CODE, IS_TTY, SPINNER, SPINNER_TICKS, TICK_INTERVAL_MS, format_checkmark,
+    icons::Icon,
 };
 use console::{Term, style};
 use std::sync::LazyLock;
@@ -113,7 +114,7 @@ impl RollingBuffer {
         let title_styled = style(&self.title).color256(CODSPEED_U8_COLOR_CODE);
 
         let line = format!("  {tick_styled} {title_styled}");
-        console::truncate_str(&line, self.term_width, "…").into_owned()
+        console::truncate_str(&line, self.term_width, &Icon::Ellipsis.to_string()).into_owned()
     }
 
     fn render_top_delimiter(&self) -> String {
@@ -126,18 +127,18 @@ impl RollingBuffer {
         } else {
             String::new()
         };
-        let prefix = format!("{INDENT}\u{256d}\u{2500}");
-        let suffix = "\u{256e}"; // ╮
+        let prefix = format!("{INDENT}{}{}", Icon::BoxTopLeft, Icon::BoxHorizontal);
+        let suffix = Icon::BoxTopRight.to_string();
         let label_visible_len = if truncated > 0 {
             format!(" {truncated} lines above ").len()
         } else {
             0
         };
         let used = console::measure_text_width(&prefix)
             + label_visible_len
-            + console::measure_text_width(suffix);
+            + console::measure_text_width(&suffix);
         let remaining = self.term_width.saturating_sub(used);
-        let bar = "\u{2500}".repeat(remaining);
+        let bar = Icon::BoxHorizontal.to_string().repeat(remaining);
         format!(
             "{}{}{}",
             style(prefix.to_string()).dim(),
@@ -147,22 +148,22 @@ impl RollingBuffer {
     }
 
     fn render_bottom_delimiter(&self) -> String {
-        let prefix = format!("{INDENT}\u{2570}");
-        let suffix = "\u{256f}"; // ╯
-        let used = console::measure_text_width(&prefix) + console::measure_text_width(suffix);
+        let prefix = format!("{INDENT}{}", Icon::BoxBottomLeft);
+        let suffix = Icon::BoxBottomRight.to_string();
+        let used = console::measure_text_width(&prefix) + console::measure_text_width(&suffix);
         let remaining = self.term_width.saturating_sub(used);
-        let bar = "\u{2500}".repeat(remaining);
+        let bar = Icon::BoxHorizontal.to_string().repeat(remaining);
         format!("{}", style(format!("{prefix}{bar}{suffix}")).dim())
     }
 
     fn render_content_line(&self, line: &str) -> String {
-        let inner_indent = format!("{INDENT}\u{2502} ");
-        let right_border = "\u{2502}"; // │
+        let inner_indent = format!("{INDENT}{} ", Icon::BoxVertical);
+        let right_border = Icon::BoxVertical.to_string();
         let chrome_width =
-            console::measure_text_width(&inner_indent) + console::measure_text_width(right_border);
+            console::measure_text_width(&inner_indent) + console::measure_text_width(&right_border);
         let max_content_width = self.term_width.saturating_sub(chrome_width);
         let truncated = if max_content_width > 0 {
-            console::truncate_str(line, max_content_width, "…")
+            console::truncate_str(line, max_content_width, &Icon::Ellipsis.to_string())
         } else {
             std::borrow::Cow::Borrowed("")
         };
@@ -173,7 +174,7 @@ impl RollingBuffer {
             style(&inner_indent).dim(),
             style(&*truncated).dim(),
             " ".repeat(padding),
-            style(right_border).dim()
+            style(&right_border).dim()
         )
     }