fix: add base addr to symbol offset#120
Merged
not-matthias merged 3 commits intoOct 1, 2025
Merged
Conversation
not-matthias
marked this pull request as ready for review
September 22, 2025 08:54
not-matthias
force-pushed
the
cod-1356-unresolved-addresses-with-pie-benchmark-executable
branch
from
September 22, 2025 08:54
db1cf59 to
a502bc9
Compare
not-matthias
requested review from
GuillaumeLagrange,
art049 and
Copilot
and removed request for
art049
September 22, 2025 08:54
There was a problem hiding this comment.
Pull Request Overview
This PR fixes symbol address calculation by adding the base address to symbol offsets instead of the load bias, and consolidates the address calculation logic between unwind_info and perf_map.
- Merged load bias and base address calculation into a shared
elf_helpermodule - Changed symbol offset calculation to use base address rather than load bias for better accuracy
- Added test coverage for
the_algorithmsbinary to verify correct address calculations
Reviewed Changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/run/runner/wall_time/perf/elf_helper.rs | New shared module containing consolidated address calculation logic |
| src/run/runner/wall_time/perf/unwind_data.rs | Refactored to use shared helper and updated function signatures |
| src/run/runner/wall_time/perf/perf_map.rs | Updated to use shared helper and improved symbol address calculation |
| src/run/runner/wall_time/perf/mod.rs | Added new elf_helper module and updated function call |
| testdata/perf_map/the_algorithms.bin | Added new test binary |
| .gitattributes | Added LFS tracking for new test binary |
| snapshots/* | Updated test snapshots reflecting the address calculation changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
not-matthias
force-pushed
the
cod-1356-unresolved-addresses-with-pie-benchmark-executable
branch
from
September 26, 2025 11:11
a502bc9 to
085ae48
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 13 out of 15 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
not-matthias
force-pushed
the
cod-1356-unresolved-addresses-with-pie-benchmark-executable
branch
from
September 26, 2025 13:09
085ae48 to
2cfe850
Compare
not-matthias
force-pushed
the
cod-1356-unresolved-addresses-with-pie-benchmark-executable
branch
3 times, most recently
from
September 29, 2025 12:59
7e28e1a to
04eaff7
Compare
art049
requested changes
Sep 30, 2025
art049
requested review from
GuillaumeLagrange
and removed request for
GuillaumeLagrange
September 30, 2025 11:47
art049
reviewed
Sep 30, 2025
GuillaumeLagrange
previously requested changes
Sep 30, 2025
not-matthias
force-pushed
the
cod-1356-unresolved-addresses-with-pie-benchmark-executable
branch
4 times, most recently
from
September 30, 2025 15:55
ab5af05 to
d03f8bd
Compare
not-matthias
force-pushed
the
cod-1356-unresolved-addresses-with-pie-benchmark-executable
branch
from
September 30, 2025 16:08
e7adb6f to
2ee3731
Compare
art049
approved these changes
Oct 1, 2025
not-matthias
deleted the
cod-1356-unresolved-addresses-with-pie-benchmark-executable
branch
October 1, 2025 09:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
unwind_infoandperf_mapthe_algorithmsto ensure we get the right addresses