Skip to content

fix(memtrack): handle dropped events better#321

Merged
not-matthias merged 2 commits intomainfrom
cod-2577-detect-or-prevent-dropped-events-in-memtrack-ringbuffer
Apr 30, 2026
Merged

fix(memtrack): handle dropped events better#321
not-matthias merged 2 commits intomainfrom
cod-2577-detect-or-prevent-dropped-events-in-memtrack-ringbuffer

Conversation

@not-matthias
Copy link
Copy Markdown
Member

No description provided.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 28, 2026

Merging this PR will not alter performance

✅ 4 untouched benchmarks


Comparing cod-2577-detect-or-prevent-dropped-events-in-memtrack-ringbuffer (96e64dd) with main (c227c9f)

Open in CodSpeed

@not-matthias not-matthias force-pushed the cod-2577-detect-or-prevent-dropped-events-in-memtrack-ringbuffer branch 2 times, most recently from 63e9074 to 51aaf98 Compare April 29, 2026 09:31
Copy link
Copy Markdown
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Add a single-slot BPF array that bpf_ringbuf_reserve() failures
atomically increment. Userspace reads it after the run completes and
bails with a guidance message if any events were dropped, since a
truncated trace would silently misreport memory usage.
@not-matthias not-matthias force-pushed the cod-2577-detect-or-prevent-dropped-events-in-memtrack-ringbuffer branch from 51aaf98 to 96e64dd Compare April 30, 2026 07:46
@not-matthias not-matthias merged commit 96e64dd into main Apr 30, 2026
19 checks passed
@not-matthias not-matthias deleted the cod-2577-detect-or-prevent-dropped-events-in-memtrack-ringbuffer branch April 30, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants