feat(logger): make announcement title configurable#325
Open
Aejkatappaja wants to merge 1 commit intoCodSpeedHQ:mainfrom
Open
feat(logger): make announcement title configurable#325Aejkatappaja wants to merge 1 commit intoCodSpeedHQ:mainfrom
Aejkatappaja wants to merge 1 commit intoCodSpeedHQ:mainfrom
Conversation
Adds a 2-arg form to the `announcement!` macro so callers can specify a contextual title alongside the message. Provider loggers (GitHub Actions, GitLab CI, Buildkite) now surface the title where supported, and fall back to their previous defaults when the 1-arg form is used. Updates the two OIDC-related announcements in the GitHub Actions provider to use the new "OIDC Authentication" title instead of relying on the generic "New CodSpeed Feature" default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a 2-arg form to the
announcement!macro so callers can specify a contextual title alongside the message. Provider loggers (GitHub Actions, GitLab CI, Buildkite) now surface the title where supported, and fall back to their previous defaults when the 1-arg form is used.Updates the two OIDC-related announcements in the GitHub Actions provider to use the new "OIDC Authentication" title instead of relying on the generic "New CodSpeed Feature" default.
Closes the
// TODO: make the announcement title configurableinsrc/run_environment/github_actions/logger.rs.Behavior
announcement!("msg")New CodSpeed Featureon GitHub Actions,[ANNOUNCEMENT]on Buildkite, none on GitLab)announcement!("title", "msg")Rendered output
Test plan
cargo build --workspacecargo fmt --all -- --checkcargo test --workspace(221 passing, +5 new unit tests for the parser)