Merging this PR will not alter performance

✅ 7 untouched benchmarks

_{Comparing cod-2839-retry-upload-on-connection-errorstimeouts (32229fd) with main (ba5799e)}

Greptile Summary

This PR adds upload retry support for streaming (on-disk) profile archives, which previously had no retry logic because the middleware cannot replay a consumed body stream. The fix introduces send_streamed_with_retry, a manual retry loop that re-opens the file on each attempt and mirrors the DefaultRetryableStrategy used by the existing REQUEST_CLIENT middleware.

• A new shared upload_backoff() factory replaces the inline ExponentialBackoff construction, ensuring both the middleware and the manual loop use identical policy parameters; a #[cfg(test)] branch shrinks the intervals to 1–5 ms so retry tests stay fast.
• send_streamed_with_retry classifies outcomes via DefaultRetryableStrategy, retrying on Transient (e.g. 503) and falling through to the caller for fatal or non-retryable responses — consistent with how the middleware handles the in-memory path.
• Two new integration tests (streamed_upload_is_retried, in_memory_upload_is_retried) spin up a raw-TCP mock that returns 503 exactly EXPECTED_ATTEMPTS times and assert both that the error surfaces and that the hit count equals 1 + UPLOAD_RETRY_COUNT.

Confidence Score: 5/5

Safe to merge — the streaming retry loop correctly mirrors the middleware classifier and policy, and both new tests validate the expected attempt counts end-to-end.

The core logic in send_streamed_with_retry is well-structured: DefaultRetryableStrategy and upload_backoff() are the same building blocks used by REQUEST_CLIENT's middleware, so both code paths are consistent. The test harness covers both the streamed and in-memory paths with real 503 responses and hit-count assertions. No production-facing regressions were identified.

No files require special attention.

Important Files Changed

sequenceDiagram
    participant U as upload_profile_archive
    participant R as send_streamed_with_retry
    participant F as File (disk)
    participant S as STREAMING_CLIENT
    participant C as Cloud Storage

    U->>R: call (path, upload_data, ...)
    loop up to 1 + UPLOAD_RETRY_COUNT attempts
        R->>F: File::open(path)
        F-->>R: stream
        R->>S: PUT upload_url (streaming body)
        S->>C: HTTP PUT
        C-->>S: 503 Service Unavailable
        S-->>R: "Ok(Response{503})"
        R->>R: "DefaultRetryableStrategy -> Transient"
        R->>R: policy.should_retry(start, n_past_retries)
        alt retries remaining
            R->>R: sleep(backoff)
            R->>R: "n_past_retries += 1"
        else retries exhausted
            R-->>U: "Ok(Response{503})"
        end
    end
    U->>U: "!status.is_success() -> bail!"

_{Reviews (3): Last reviewed commit: "fix(upload): retry streamed uploads on t..." | Re-trigger Greptile}