Skip to content

Commit 2e710af

Browse files
paulfloydMark Wielaard
authored andcommitted
FreeBSD regtest: updates for FreeBSD 15.0-CURRENT
Mostly minor expected/filter changes. Helgrind did detect a race condition in a Valgrind file static variable. Teh DRD dlopen test needs to be linked with the thread library. In a VirtualBox environment I'm getting 4 hanging testcases (3 in gdbserver_tests and none/freebsd/bug452274). (cherry picked from commit 8dbf867)
1 parent b90959c commit 2e710af

14 files changed

Lines changed: 33 additions & 31 deletions

drd/tests/Makefile.am

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -550,7 +550,9 @@ bug322621_SOURCES = bug322621.cpp
550550
condvar_SOURCES = condvar.cpp
551551
condvar_CXXFLAGS = $(AM_CXXFLAGS) -std=c++0x
552552
concurrent_close_SOURCES = concurrent_close.cpp
553-
if !VGCONF_OS_IS_FREEBSD
553+
if VGCONF_OS_IS_FREEBSD
554+
dlopen_main_LDADD = ${LDADD}
555+
else
554556
dlopen_main_LDADD = -ldl
555557
endif
556558
dlopen_lib_so_SOURCES = dlopen_lib.c

freebsd-helgrind.supp

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,4 +238,9 @@
238238
Helgrind:Race
239239
fun:thr_exit
240240
}
241-
241+
# sigh, this is our own variable in coregrind/m_replacemalloc/vg_replace_malloc.c
242+
{
243+
FREEBSD15-AMD64-MALLOC
244+
Helgrind:Race
245+
fun:malloc
246+
}

helgrind/tests/Makefile.am

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ dist_noinst_SCRIPTS = \
55
filter_stderr_solaris \
66
filter_helgrind \
77
filter_xml \
8+
filter_fiw \
89
filter_freebsd.awk \
910
filter_stderr_freebsd \
1011
filter_bug392331

helgrind/tests/filter_fiw

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
#! /bin/sh
2+
3+
# free_is_write may have different arena sizes
4+
5+
./filter_stderr "$@" |
6+
7+
sed 's/size [^ ]* in arena/size ... in arena/'
8+

helgrind/tests/free_is_write.stderr.exp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Locks held: none
2323
This conflicts with a previous read of size 1 by thread #x
2424
Locks held: none
2525
at 0x........: main (free_is_write.c:36)
26-
Address 0x........ is 5 bytes inside an unallocated block of size 16 in arena "client"
26+
Address 0x........ is 5 bytes inside an unallocated block of size ... in arena "client"
2727

2828
Done.
2929

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
prog: free_is_write
22
vgopts: --free-is-write=yes
3+
stderr_filter: filter_fiw

memcheck/tests/Makefile.am

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ dist_noinst_SCRIPTS = \
8686
filter_varinfo3 \
8787
filter_memcheck \
8888
filter_malloc_free \
89+
filter_sendmsg \
8990
filter_size_t \
9091
filter_stanza \
9192
filter_stanza.awk \
@@ -381,7 +382,6 @@ EXTRA_DIST = \
381382
sem.stderr.exp sem.vgtest \
382383
sendmsg.stderr.exp sendmsg.stderr.exp-solaris sendmsg.vgtest \
383384
sendmsg.stderr.exp-freebsd \
384-
sendmsg.stderr.exp-freebsd-x86 \
385385
sh-mem.stderr.exp sh-mem.vgtest \
386386
sh-mem-random.stderr.exp sh-mem-random.stdout.exp64 \
387387
sh-mem-random.stdout.exp sh-mem-random.vgtest \

memcheck/tests/filter_sendmsg

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
#! /bin/sh
2+
3+
./filter_stderr "$@" |
4+
sed -e "s/frame #./frame #.../" \
5+
-e "/by 0x........: sendmsg (in \/...libc...)/d"

memcheck/tests/sendmsg.stderr.exp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@ Syscall param sendmsg(msg) points to uninitialised byte(s)
22
at 0x........: sendmsg (in /...libc...)
33
by 0x........: main (sendmsg.c:46)
44
Address 0x........ is on thread 1's stack
5-
in frame #1, created by main (sendmsg.c:13)
5+
in frame #..., created by main (sendmsg.c:13)
66

77
sendmsg: 6

memcheck/tests/sendmsg.stderr.exp-freebsd

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,18 @@ Syscall param socketcall.connect(serv_addr.sa_len) points to uninitialised byte(
22
...
33
by 0x........: main (sendmsg.c:29)
44
Address 0x........ is on thread 1's stack
5-
in frame #1, created by main (sendmsg.c:13)
5+
in frame #..., created by main (sendmsg.c:13)
66

77
Syscall param sendmsg(sendmsg) points to uninitialised byte(s)
88
at 0x........: _sendmsg (in /...libc...)
9-
by 0x........: sendmsg (in /...libc...)
109
by 0x........: main (sendmsg.c:46)
1110
Address 0x........ is on thread 1's stack
12-
in frame #2, created by main (sendmsg.c:13)
11+
in frame #..., created by main (sendmsg.c:13)
1312

1413
Syscall param socketcall.connect(serv_addr.sa_len) points to uninitialised byte(s)
1514
...
1615
by 0x........: main (sendmsg.c:59)
1716
Address 0x........ is on thread 1's stack
18-
in frame #1, created by main (sendmsg.c:13)
17+
in frame #..., created by main (sendmsg.c:13)
1918

2019
sendmsg: 6

0 commit comments

Comments
 (0)