chore: add justfile to build valgrind locally and from upstream

Author: not-matthias

.github/workflows/codspeed.yml

@@ -16,8 +16,10 @@ jobs:
         benchmark:
           - testdata/take_strings-aarch64
         valgrind:
-          - /bin/valgrind
-          - ../vg-in-place
+          - "3.26.0"
+          - "3.25.0"
+          - "3.24.0"
+          - "local"
     steps:
       - uses: actions/checkout@v4
         with:
@@ -38,18 +40,9 @@ jobs:
       - name: Update apt-get cache
         run: sudo apt-get update
 
-      # Install upstream Valgrind for comparison
-      - name: Install upstream Valgrind
-        run: |
-          # Macro runners already have valgrind pre-installed, so we have to remove it first
-          sudo apt-get remove -y valgrind || true
-
-          # Install the actual upstream valgrind package
-          sudo apt-get install -y valgrind
-          which valgrind
-          which -a valgrind
-          /usr/bin/valgrind --version
-          /bin/valgrind --version
+      # Remove any existing Valgrind installation to avoid conflicts
+      - name: Remove existing Valgrind installation
+        run: sudo apt-get remove -y valgrind || true
 
       - name: Install build dependencies
         run: |
@@ -64,27 +57,12 @@ jobs:
             docbook-xml \
             xsltproc
 
-      - name: Run autogen
-        run: ./autogen.sh
-
-      - name: Configure
-        run: ./configure
-
-      - name: Build Valgrind
-        run: |
-          make include/vgversion.h 
-          make -j$(nproc) -C VEX
-          make -j$(nproc) -C coregrind
-          make -j$(nproc) -C callgrind
+      - uses: extractions/setup-just@v3
+      - name: Build Valgrind (${{ matrix.valgrind }})
+        run: just build ${{ matrix.valgrind }}
 
       - name: Verify Valgrind build
-        run: |
-          # Verify that vg-in-place script exists
-          test -f ./vg-in-place || { echo "vg-in-place not found!"; exit 1; }
-          # Test valgrind works with vg-in-place
-          ./vg-in-place --version
-          ./vg-in-place --tool=callgrind --help > /dev/null || { echo "callgrind tool not accessible!"; exit 1; }
-          echo "Valgrind build successful and callgrind tool is accessible"
+        run: /usr/local/bin/valgrind --version
 
       # Setup benchmarks and run them
       - name: Install uv
@@ -100,4 +78,4 @@ jobs:
           cache-instruments: false
           working-directory: bench
           mode: walltime
-          run: uv run bench.py --binary-path ${{ matrix.benchmark }} --valgrind-path ${{ matrix.valgrind }}
+          run: uv run bench.py --binary-path ${{ matrix.benchmark }} --valgrind-path /usr/local/bin/valgrind

Justfile

@@ -0,0 +1,49 @@
+# Builds a specific valgrind version
+# Usage:
+# - just build 3.24.0: Downloads the specified version from sourceware.org, builds and installs it
+# - just build local: Builds the local Valgrind source in the current directory
+build version:
+    #!/usr/bin/env bash
+    set -euo pipefail
+
+    if [ "{{ version }}" = "local" ]; then
+        just build-in "."
+    else
+        just build-upstream "{{ version }}"
+    fi
+
+build-in dir:
+    #!/usr/bin/env bash
+    set -euo pipefail
+    cd "{{ dir }}"
+
+    # Check if we need to run autogen.sh (for git checkouts)
+    if [ -f "autogen.sh" ] && [ ! -f "configure" ]; then
+        ./autogen.sh
+    fi
+
+    ./configure
+    make include/vgversion.h
+    make -j$(nproc) -C VEX
+    make -j$(nproc) -C coregrind
+    make -j$(nproc) -C callgrind
+    echo "Valgrind build complete in {{ dir }}"
+
+    # Install Valgrind
+    sudo make install
+    /usr/local/bin/valgrind --version
+
+# Download, build and install upstream Valgrind from sourceware.org
+build-upstream version:
+    #!/usr/bin/env bash
+    set -euo pipefail
+
+    # Download and extract upstream Valgrind
+    mkdir -p /tmp/valgrind-upstream
+    cd /tmp/valgrind-upstream
+    rm -rf valgrind-{{ version }}*
+    wget -q https://sourceware.org/pub/valgrind/valgrind-{{ version }}.tar.bz2
+    tar -xjf valgrind-{{ version }}.tar.bz2
+
+    # Build and install using absolute path
+    just build-in "/tmp/valgrind-upstream/valgrind-{{ version }}"