Skip to content

Commit e2db507

Browse files
not-matthiasnot-matthias
committed
chore: dont redact full flamegraph
1 parent 6f0af04 commit e2db507

7 files changed

Lines changed: 111 additions & 78 deletions

‎callgrind-utils/tests/snapshot.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,6 @@ fn fixture_full_trace(#[case] stem: &str) {
135135
let graph = CallGraph::parse(Cursor::new(raw.as_str()), &ParseOptions::default())
136136
.unwrap_or_else(|e| panic!("parse {stem} full callgrind output: {e:?}"));
137137
graph.to_flamegraph_file(format!("{stem}.full.svg")).unwrap();
138-
let json = graph.redact().to_json().expect("to_json");
138+
let json = graph.to_json().expect("to_json");
139139
insta::assert_snapshot!(format!("{stem}_full__json"), json);
140140
}

‎callgrind-utils/tests/snapshots/python_callgraph__recursion_py__topology_json.snap‎

Lines changed: 26 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@ expression: json
44
---
55
{
66
"nodes": [
7+
{
8+
"function": "GenericPyCData_new",
9+
"file": "???",
10+
"object": "_ctypes.cpython.so"
11+
},
712
{
813
"function": "KeepRef",
914
"file": "???",
@@ -34,11 +39,6 @@ expression: json
3439
"file": "???",
3540
"object": "_ctypes.cpython.so"
3641
},
37-
{
38-
"function": "_validate_paramflags",
39-
"file": "???",
40-
"object": "_ctypes.cpython.so"
41-
},
4242
{
4343
"function": "i_get",
4444
"file": "???",
@@ -111,42 +111,50 @@ expression: json
111111
},
112112
{
113113
"caller": 1,
114-
"callee": 3
114+
"callee": 8
115+
},
116+
{
117+
"caller": 1,
118+
"callee": 9
115119
},
116120
{
117121
"caller": 2,
122+
"callee": 4
123+
},
124+
{
125+
"caller": 3,
118126
"callee": 0
119127
},
120128
{
121-
"caller": 2,
122-
"callee": 5
129+
"caller": 3,
130+
"callee": 1
123131
},
124132
{
125-
"caller": 2,
133+
"caller": 3,
126134
"callee": 6
127135
},
128136
{
129-
"caller": 2,
137+
"caller": 3,
130138
"callee": 8
131139
},
132140
{
133-
"caller": 2,
141+
"caller": 3,
134142
"callee": 9
135143
},
136144
{
137-
"caller": 3,
145+
"caller": 4,
138146
"callee": 8
139147
},
140148
{
141-
"caller": 3,
149+
"caller": 4,
142150
"callee": 9
143151
},
144152
{
145-
"caller": 3,
153+
"caller": 4,
146154
"callee": 12
147155
},
148156
{
149-
"caller": 3,
157+
"caller": 4,
150158
"callee": 17
151159
},
152160
{
@@ -159,11 +167,11 @@ expression: json
159167
},
160168
{
161169
"caller": 9,
162-
"callee": 1
170+
"callee": 2
163171
},
164172
{
165173
"caller": 9,
166-
"callee": 2
174+
"callee": 3
167175
},
168176
{
169177
"caller": 9,
@@ -179,7 +187,7 @@ expression: json
179187
},
180188
{
181189
"caller": 11,
182-
"callee": 4
190+
"callee": 5
183191
},
184192
{
185193
"caller": 11,

‎callgrind-utils/tests/snapshots/snapshot__chain_full__json.snap‎

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,18 @@ expression: json
3030
"object": "chain"
3131
},
3232
{
33-
"function": "???",
33+
"function": "0x000000000001d5c0",
3434
"file": "???",
35-
"object": "ld-linux"
35+
"object": "ld-linux-x86-64.so.2"
3636
},
3737
{
38-
"function": "???",
39-
"file": "???",
38+
"function": "__libc_start_main@@GLIBC_2.34",
39+
"file": "libc-start.c",
40+
"object": "libc.so.6"
41+
},
42+
{
43+
"function": "(below main)",
44+
"file": "libc_start_call_main.h",
4045
"object": "libc.so.6"
4146
}
4247
],
@@ -68,12 +73,12 @@ expression: json
6873
},
6974
{
7075
"caller": 6,
71-
"callee": 4,
76+
"callee": 7,
7277
"call_count": 0
7378
},
7479
{
75-
"caller": 6,
76-
"callee": 6,
80+
"caller": 7,
81+
"callee": 4,
7782
"call_count": 0
7883
}
7984
]

‎callgrind-utils/tests/snapshots/snapshot__diamond_full__json.snap‎

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,18 @@ expression: json
3535
"object": "diamond"
3636
},
3737
{
38-
"function": "???",
38+
"function": "0x000000000001d5c0",
3939
"file": "???",
40-
"object": "ld-linux"
40+
"object": "ld-linux-x86-64.so.2"
4141
},
4242
{
43-
"function": "???",
44-
"file": "???",
43+
"function": "__libc_start_main@@GLIBC_2.34",
44+
"file": "libc-start.c",
45+
"object": "libc.so.6"
46+
},
47+
{
48+
"function": "(below main)",
49+
"file": "libc_start_call_main.h",
4550
"object": "libc.so.6"
4651
}
4752
],
@@ -83,12 +88,12 @@ expression: json
8388
},
8489
{
8590
"caller": 7,
86-
"callee": 3,
91+
"callee": 8,
8792
"call_count": 0
8893
},
8994
{
90-
"caller": 7,
91-
"callee": 7,
95+
"caller": 8,
96+
"callee": 3,
9297
"call_count": 0
9398
}
9499
]

‎callgrind-utils/tests/snapshots/snapshot__fractal_full__json.snap‎

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -145,13 +145,18 @@ expression: json
145145
"object": "fractal"
146146
},
147147
{
148-
"function": "???",
148+
"function": "0x000000000001d5c0",
149149
"file": "???",
150-
"object": "ld-linux"
150+
"object": "ld-linux-x86-64.so.2"
151151
},
152152
{
153-
"function": "???",
154-
"file": "???",
153+
"function": "__libc_start_main@@GLIBC_2.34",
154+
"file": "libc-start.c",
155+
"object": "libc.so.6"
156+
},
157+
{
158+
"function": "(below main)",
159+
"file": "libc_start_call_main.h",
155160
"object": "libc.so.6"
156161
}
157162
],
@@ -393,12 +398,12 @@ expression: json
393398
},
394399
{
395400
"caller": 29,
396-
"callee": 17,
401+
"callee": 30,
397402
"call_count": 0
398403
},
399404
{
400-
"caller": 29,
401-
"callee": 29,
405+
"caller": 30,
406+
"callee": 17,
402407
"call_count": 0
403408
}
404409
]

‎callgrind-utils/tests/snapshots/snapshot__mutual_full__json.snap‎

Lines changed: 24 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,18 @@ expression: json
55
{
66
"nodes": [
77
{
8-
"function": "???",
8+
"function": "0x000000000001d5c0",
99
"file": "???",
10-
"object": "ld-linux"
10+
"object": "ld-linux-x86-64.so.2"
1111
},
1212
{
13-
"function": "???",
14-
"file": "???",
13+
"function": "__libc_start_main@@GLIBC_2.34",
14+
"file": "libc-start.c",
15+
"object": "libc.so.6"
16+
},
17+
{
18+
"function": "(below main)",
19+
"file": "libc_start_call_main.h",
1520
"object": "libc.so.6"
1621
},
1722
{
@@ -48,47 +53,47 @@ expression: json
4853
"edges": [
4954
{
5055
"caller": 0,
51-
"callee": 2,
56+
"callee": 3,
5257
"call_count": 0
5358
},
5459
{
5560
"caller": 1,
56-
"callee": 1,
61+
"callee": 2,
5762
"call_count": 0
5863
},
5964
{
60-
"caller": 1,
61-
"callee": 7,
65+
"caller": 2,
66+
"callee": 8,
6267
"call_count": 0
6368
},
6469
{
65-
"caller": 2,
70+
"caller": 3,
6671
"callee": 1,
6772
"call_count": 0
6873
},
6974
{
70-
"caller": 3,
71-
"callee": 5,
75+
"caller": 4,
76+
"callee": 6,
7277
"call_count": 1
7378
},
7479
{
75-
"caller": 4,
76-
"callee": 6,
80+
"caller": 5,
81+
"callee": 7,
7782
"call_count": 2
7883
},
7984
{
80-
"caller": 5,
81-
"callee": 4,
85+
"caller": 6,
86+
"callee": 5,
8287
"call_count": 1
8388
},
8489
{
85-
"caller": 6,
86-
"callee": 4,
90+
"caller": 7,
91+
"callee": 5,
8792
"call_count": 2
8893
},
8994
{
90-
"caller": 7,
91-
"callee": 3,
95+
"caller": 8,
96+
"callee": 4,
9297
"call_count": 1
9398
}
9499
]

0 commit comments

Comments
 (0)