Skip to content

Commit ece679d

Browse files
committed
Revert "fix(callgrind): drop BBCCs whose top context fn is skip-flagged"
This reverts commit bcfb4c9.
1 parent bcfb4c9 commit ece679d

2 files changed

Lines changed: 2 additions & 12 deletions

File tree

callgrind/dump.c

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1553,17 +1553,7 @@ static void print_bbccs_of_thread(thread_info* ti)
15531553
}
15541554

15551555
if (*p == 0) break;
1556-
1557-
/* Don't emit BBCCs whose top context fn is flagged for obj-skip.
1558-
* This happens when the (cxt == 0) clause in setup_bbcc force-
1559-
* pushes a skipped fn (first BB after instrumentation start that
1560-
* landed in a skipped object). Without this filter the skipped fn
1561-
* leaks into the dump as a top-level fn= block. */
1562-
if ((*p)->cxt->fn[0]->skip) {
1563-
p++;
1564-
continue;
1565-
}
1566-
1556+
15671557
if (print_fn_pos(print_fp, &lastFnPos, *p)) {
15681558

15691559
/* new function */
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
prereq: test -f runtime_obj_skip_c && test -f runtime_obj_skip_c_lib.so
22
prog-asis: ./runtime_obj_skip_c
33
vgopts: --instr-atstart=no --compress-strings=no --callgrind-out-file=callgrind.out.runtime_obj_skip_c
4-
post: sh -c 'if grep -q "^fn=skipme" callgrind.out.runtime_obj_skip_c; then echo "FAIL: skipme_* leaked into top-level fn= block"; else echo OK; fi'
4+
post: sh -c 'if grep -q "^fn=skipme_func" callgrind.out.runtime_obj_skip_c; then echo "FAIL: skipme_func leaked into top-level fn= block"; else echo OK; fi'
55
cleanup: rm -f callgrind.out.runtime_obj_skip_c

0 commit comments

Comments
 (0)