-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/fix unit tests #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
891bae7
4f17190
941d67b
ba45842
aef2635
936045f
93a60bc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -48,7 +48,6 @@ class BookDetailsViewModel extends Bloc<BookDetailsEvent, BookDetailsState> { | |
| final bookDetails = await _getBookDetails(id: bookId!); | ||
| return BookDetailsUI.fromDomain(bookDetails); | ||
| } else { | ||
| emit(state.copyWith(errorMessage: "Book ID is null")); | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove this considering we are already emitting the state in the proper method caller (dart analyze pointed an issue here, we cannot emit without being in a scope of event (on ...)
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well considered 👍 |
||
| return null; | ||
| } | ||
| } | ||
|
|
||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove commented test |
This file was deleted.
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Solve unit tests issue |
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove generated test (not used) |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a new step before run the tests considering Mock framework generates code