Ja vr private descriptions#131
Open
vrautela wants to merge 10 commits into
Open
Conversation
varunthakkar1
previously requested changes
Jul 21, 2021
Contributor
There was a problem hiding this comment.
You need to add similar get and set methods for the autogenerated jooq classes, otherwise your route and tests are not going to work.
I like the logic you used though. I think it will work if you do it this way.
I also need verification that the route works, so you may need to do Postman testing
varunthakkar1
approved these changes
Aug 2, 2021
ja0911
reviewed
Aug 5, 2021
| } | ||
|
|
||
| // hide the private description if the user isn't registered and they're not an admin | ||
| if (!userRegisteredForEvent && userData.getPrivilegeLevel() != PrivilegeLevel.ADMIN) { |
Contributor
There was a problem hiding this comment.
@varunthakkar1 This line should allow admins to always see the private description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
What benefit does this bring to the end user? Or, what benefit does this bring to developers
working in the codebase?
Ticket #163
This PR
Create/edit event forms should now include private descriptions
Backend/DB must hold a string field for private descriptions
API must respond with extra private description field
Frontend must display this field when registered users view the event on the single event view page