fix: retry rest after blank live transcript

Author: Donach

app/src/main/java/com/whispertranscriber/network/WhisperApiClient.kt

@@ -109,3 +109,6 @@ data class TranscriptionResult(
     val text: String,
     val error: String? = null
 )
+
+fun TranscriptionResult.shouldRetryRestAfterLive(): Boolean =
+    success && text.isBlank()

app/src/main/java/com/whispertranscriber/service/FloatingOverlayService.kt

@@ -34,6 +34,7 @@ import com.whispertranscriber.network.WhisperLiveKitClient
 import com.whispertranscriber.network.WhisperLiveKitSession
 import com.whispertranscriber.network.WhisperServerDiscovery
 import com.whispertranscriber.network.TranscriptionResult
+import com.whispertranscriber.network.shouldRetryRestAfterLive
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.Job
@@ -257,9 +258,11 @@ class FloatingOverlayService : Service() {
                 val serverUrl = resolveServerUrl(settings.whisperServerUrl)
                 val session = liveKitSession
                 liveKitSession = null
-                val result = liveResult ?: if (liveKitReady && session != null) {
+                val result = liveResult?.let {
+                    retryRestIfLiveResultIsBlank(serverUrl, wavData, it)
+                } ?: if (liveKitReady && session != null) {
                     try {
-                        session.finish()
+                        retryRestIfLiveResultIsBlank(serverUrl, wavData, session.finish())
                     } catch (e: Exception) {
                         Log.w(TAG, "Live transcription finalization failed, retrying with REST", e)
                         whisperClient.transcribe(
@@ -312,6 +315,19 @@ class FloatingOverlayService : Service() {
         }
     }
 
+    private suspend fun retryRestIfLiveResultIsBlank(
+        serverUrl: String,
+        wavData: ByteArray,
+        liveResult: TranscriptionResult
+    ): TranscriptionResult {
+        if (!liveResult.shouldRetryRestAfterLive()) return liveResult
+        Log.w(TAG, "Live transcription returned empty text, retrying with REST")
+        return whisperClient.transcribe(
+            serverUrl = serverUrl,
+            audioData = wavData
+        )
+    }
+
     private fun handleLivePartial(partial: String) {
         transcriptionText = partial
         if (realtimeInsertionActive) {

app/src/test/java/com/whispertranscriber/network/TranscriptionResultPolicyTest.kt

@@ -0,0 +1,29 @@
+package com.whispertranscriber.network
+
+import org.junit.Assert.assertFalse
+import org.junit.Assert.assertTrue
+import org.junit.Test
+
+class TranscriptionResultPolicyTest {
+
+    @Test
+    fun blankSuccessfulLiveResultShouldRetryWithRest() {
+        val result = TranscriptionResult(success = true, text = "")
+
+        assertTrue(result.shouldRetryRestAfterLive())
+    }
+
+    @Test
+    fun nonBlankSuccessfulLiveResultShouldNotRetryWithRest() {
+        val result = TranscriptionResult(success = true, text = "hello")
+
+        assertFalse(result.shouldRetryRestAfterLive())
+    }
+
+    @Test
+    fun failedLiveResultShouldNotBeTreatedAsNoSpeech() {
+        val result = TranscriptionResult(success = false, text = "", error = "socket failed")
+
+        assertFalse(result.shouldRetryRestAfterLive())
+    }
+}