serial: Use newFileHandleDupFd in newVZFileHandleSerialPortAttachment

NewFileHandleSerialPortAttachment has similar limitations as
NewDiskBlockDeviceStorageDeviceAttachment.
This commit fixes this by using newFileHandleDupFd to implement it.

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>

Author: cfergeau

serial_console.go

@@ -49,14 +49,19 @@ func NewFileHandleSerialPortAttachment(read, write *os.File) (*FileHandleSerialP
 		return nil, err
 	}
 
+	nserrPtr := newNSErrorAsNil()
 	attachment := &FileHandleSerialPortAttachment{
 		pointer: objc.NewPointer(
 			C.newVZFileHandleSerialPortAttachment(
 				C.int(read.Fd()),
 				C.int(write.Fd()),
+				&nserrPtr,
 			),
 		),
 	}
+	if err := newNSError(nserrPtr); err != nil {
+		return nil, err
+	}
 	objc.SetFinalizer(attachment, func(self *FileHandleSerialPortAttachment) {
 		objc.Release(self)
 	})

virtualization_11.h

@@ -86,7 +86,7 @@ void setStorageDevicesVZVirtualMachineConfiguration(void *config,
 void *storageDevicesVZVirtualMachineConfiguration(void *config);
 
 /* Configurations */
-void *newVZFileHandleSerialPortAttachment(int readFileDescriptor, int writeFileDescriptor);
+void *newVZFileHandleSerialPortAttachment(int readFileDescriptor, int writeFileDescriptor, void **error);
 void *newVZFileSerialPortAttachment(const char *filePath, bool shouldAppend, void **error);
 void *newVZVirtioConsoleDeviceSerialPortConfiguration(void *attachment);
 void *VZBridgedNetworkInterface_networkInterfaces(void);

virtualization_11.m

@@ -448,13 +448,20 @@ void setStorageDevicesVZVirtualMachineConfiguration(void *config,
  @discussion
     Each file descriptor must a valid.
 */
-void *newVZFileHandleSerialPortAttachment(int readFileDescriptor, int writeFileDescriptor)
+void *newVZFileHandleSerialPortAttachment(int readFileDescriptor, int writeFileDescriptor, void **error)
 {
     if (@available(macOS 11, *)) {
         VZFileHandleSerialPortAttachment *ret;
         @autoreleasepool {
-            NSFileHandle *fileHandleForReading = [[NSFileHandle alloc] initWithFileDescriptor:readFileDescriptor];
-            NSFileHandle *fileHandleForWriting = [[NSFileHandle alloc] initWithFileDescriptor:writeFileDescriptor];
+            NSFileHandle *fileHandleForReading = newFileHandleDupFd(readFileDescriptor, error);
+            if (error != nil) {
+                return nil;
+            }
+
+            NSFileHandle *fileHandleForWriting = newFileHandleDupFd(writeFileDescriptor, error);
+            if (error != nil) {
+                return nil;
+            }
             ret = [[VZFileHandleSerialPortAttachment alloc]
                 initWithFileHandleForReading:fileHandleForReading
                         fileHandleForWriting:fileHandleForWriting];