network: Use newFileHandleDupFd in newVZFileHandleNetworkDeviceAttachment

NewFileHandleNetworkDeviceAttachment has similar limitations as
NewDiskBlockDeviceStorageDeviceAttachment.
This commit fixes this by using newFileHandleDupFd to implement it.

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>

Author: cfergeau

network.go

@@ -192,14 +192,20 @@ func NewFileHandleNetworkDeviceAttachment(file *os.File) (*FileHandleNetworkDevi
 		return nil, err
 	}
 
+	nserrPtr := newNSErrorAsNil()
+
 	attachment := &FileHandleNetworkDeviceAttachment{
 		pointer: objc.NewPointer(
 			C.newVZFileHandleNetworkDeviceAttachment(
 				C.int(file.Fd()),
+				&nserrPtr,
 			),
 		),
 		mtu: 1500, // The default MTU is 1500.
 	}
+	if err := newNSError(nserrPtr); err != nil {
+		return nil, err
+	}
 	objc.SetFinalizer(attachment, func(self *FileHandleNetworkDeviceAttachment) {
 		objc.Release(self)
 	})

virtualization_11.h

@@ -94,7 +94,7 @@ const char *VZBridgedNetworkInterface_identifier(void *networkInterface);
 const char *VZBridgedNetworkInterface_localizedDisplayName(void *networkInterface);
 void *newVZBridgedNetworkDeviceAttachment(void *networkInterface);
 void *newVZNATNetworkDeviceAttachment(void);
-void *newVZFileHandleNetworkDeviceAttachment(int fileDescriptor);
+void *newVZFileHandleNetworkDeviceAttachment(int fileDescriptor, void **error);
 void *newVZVirtioNetworkDeviceConfiguration(void *attachment);
 void setNetworkDevicesVZMACAddress(void *config, void *macAddress);
 void *newVZVirtioEntropyDeviceConfiguration(void);

virtualization_11.m

@@ -602,12 +602,15 @@ void setStorageDevicesVZVirtualMachineConfiguration(void *config,
  @see VZNetworkDeviceConfiguration
  @see VZVirtioNetworkDeviceConfiguration
  */
-void *newVZFileHandleNetworkDeviceAttachment(int fileDescriptor)
+void *newVZFileHandleNetworkDeviceAttachment(int fileDescriptor, void **error)
 {
     if (@available(macOS 11, *)) {
         VZFileHandleNetworkDeviceAttachment *ret;
         @autoreleasepool {
-            NSFileHandle *fileHandle = [[NSFileHandle alloc] initWithFileDescriptor:fileDescriptor];
+            NSFileHandle *fileHandle = newFileHandleDupFd(fileDescriptor, error);
+            if (fileHandle == nil) {
+                return nil;
+            }
             ret = [[VZFileHandleNetworkDeviceAttachment alloc] initWithFileHandle:fileHandle];
         }
         return ret;