Skip to content

Commit dcfe1aa

Browse files
authored
Merge pull request #75 from Code-dot-mil/hshah-mitre-patch-1
Enhance deploy workflow with updated comments and actions
2 parents a7ea1a6 + 1572941 commit dcfe1aa

1 file changed

Lines changed: 3 additions & 8 deletions

File tree

.github/workflows/deploy.yml

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ jobs:
6060
6161
# Add a comment with the S3 preview link
6262
PR_NUMBER=${{ github.event.pull_request.number }}
63-
COMMENT="Preview your changes at: http://${{ secrets.S3_BUCKET_NAME }}/mergeRequest/${PR_NUMBER}/index.html"
63+
COMMENT="Please review the changes at the following site: http://${{ secrets.S3_BUCKET_NAME }}/mergeRequest/${PR_NUMBER}/index.html"
6464
curl -X POST \
6565
-H "Authorization: token $GITHUB_TOKEN" \
6666
-H "Accept: application/vnd.github+json" \
@@ -159,12 +159,7 @@ jobs:
159159
with:
160160
name: site
161161
path: site
162-
#- name: Configure AWS credentials
163-
# uses: aws-actions/configure-aws-credentials@v4
164-
# with:
165-
# aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
166-
# aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
167-
# aws-region: us-east-1 # change if needed
162+
168163
- name: configure aws credentials
169164
uses: aws-actions/configure-aws-credentials@v2
170165
with:
@@ -193,7 +188,7 @@ jobs:
193188
if: github.ref == 'refs/heads/main' # Run for main branch
194189
steps:
195190
- name: configure aws credentials
196-
uses: aws-actions/configure-aws-credentials@v1.7.0
191+
uses: aws-actions/configure-aws-credentials@v2
197192
with:
198193
role-to-assume: arn:aws:iam::677043464939:role/GitHubAction-AssumeRoleWithAction
199194
role-session-name: GitHub_to_AWS_via_FederatedOIDC

0 commit comments

Comments
 (0)