Skip to content

Simplify PR number retrieval in deploy workflow #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hshah-mitre merged 5 commits into from
Dec 23, 2025
Merged

Simplify PR number retrieval in deploy workflow #84

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1b11cfb
Simplify PR number retrieval in deploy workflow
hshah-mitre Dec 23, 2025
c73bfef
Modify deployment workflow for debugging
hshah-mitre Dec 23, 2025
ffe6c27
Refactor PR_NUMBER handling in deploy.yml
hshah-mitre Dec 23, 2025
f88b45d
Update pull request types and PR number retrieval
hshah-mitre Dec 23, 2025
6792330
Update deployment condition for production
hshah-mitre Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 10 additions & 22 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
- "*"

pull_request:
types: [opened, ready_for_review, synchronize]
types: [opened, ready_for_review, synchronize, closed]

pull_request_review:
types: [submitted]
Expand Down Expand Up @@ -185,7 +185,11 @@ jobs:
# Deployment to production folder in S3 bucket
deploy_to_production:
runs-on: ubuntu-latest
if: github.ref == 'refs/heads/main' # Run for main branch
#if: github.ref == 'refs/heads/main' # Run for main branch
if: github.event_name == 'pull_request' &&
github.event.action == 'closed' &&
github.event.pull_request.merged == true &&
github.event.pull_request.base.ref == 'main'
steps:
- name: configure aws credentials
uses: aws-actions/configure-aws-credentials@v2
Expand All @@ -212,31 +216,15 @@ jobs:
run: |
echo "inside pr_number=$PR_NUMBER"
echo "Before pr_number=$PR_NUMBER"

# Query all pull requests (open, closed, and merged)
PR_API_URL="https://api.github.com/repos/${GITHUB_REPOSITORY}/pulls"
PR_NUMBER=$(curl -s -H "Accept: application/vnd.github.v3+json" \
-H "Authorization: Bearer $GITHUB_TOKEN" \
$PR_API_URL | jq '.[] | select(.head.sha == "'${GITHUB_SHA}'") | .number')

# Fallback: Retrieve PR number from GITHUB_EVENT_PATH if API fails
if [ -z "$PR_NUMBER" ]; then
echo "PR number not found via API. Attempting fallback..."
PR_NUMBER=$(jq -r '.pull_request.number // empty' < "$GITHUB_EVENT_PATH")
fi

if [ -z "$PR_NUMBER" ]; then
echo "No PR associated with this commit. Skipping deployment."
exit 0
fi


PR_NUMBER=${{ github.event.pull_request.number }}
echo "USING PR_NUMBER =$PR_NUMBER"

#PR_API_URL="https://api.github.com/repos/${GITHUB_REPOSITORY}/commits/${GITHUB_SHA}/pulls"
#PR_NUMBER=$(curl -s -H "Accept: application/vnd.github.groot-preview+json" \
# -H "Authorization: Bearer $GITHUB_TOKEN" \
# $PR_API_URL | jq '.[0].number')
#echo "after pr_number=$PR_NUMBER"
echo "after pr_number=$PR_NUMBER"

aws s3 sync s3://$S3_BUCKET_NAME/mergeRequest/$PR_NUMBER s3://$S3_BUCKET_NAME/production/
echo "deploy complete to production !!!"
# Delete contents of the pr folder
Expand Down