Move CLI details into edit sheet

Author: rodion-m

Sources/App/Views/ManagementViews.swift

@@ -65,6 +65,7 @@ struct CLISecretsView: View {
     @State private var pendingUnregister: CLIRegistrationSummary?
     @State private var deleteSecrets = false
     @State private var showingPolicyEditor = false
+    @State private var editingCLIName: String?
 
     var body: some View {
         ControlPlanePageFrame(
@@ -86,14 +87,9 @@ struct CLISecretsView: View {
             } else if store.filteredCLIRegistrations.isEmpty {
                 NoMatchingCLIView(store: store)
             } else {
-                HSplitView {
-                    CLIRegistrationTable(store: store)
-                        .frame(minWidth: 560, idealWidth: 700)
-                    CLIRegistrationDetail(
-                        store: store,
-                        pendingUnregister: $pendingUnregister
-                    )
-                    .frame(minWidth: 460)
+                CLIRegistrationTable(store: store) { cliName in
+                    store.selectedCLI = cliName
+                    editingCLIName = cliName
                 }
                 .frame(minHeight: 460)
             }
@@ -102,6 +98,16 @@ struct CLISecretsView: View {
             CLIDeliveryPolicyEditorSheet(store: store)
                 .frame(width: 900, height: 720)
         }
+        .sheet(isPresented: Binding(
+            get: { editingCLIName != nil },
+            set: { if !$0 { editingCLIName = nil } }
+        )) {
+            CLIRegistrationEditorSheet(
+                store: store,
+                pendingUnregister: $pendingUnregister
+            )
+            .frame(width: 760, height: 760)
+        }
         .confirmationDialog("Unregister CLI?", isPresented: Binding(
             get: { pendingUnregister != nil },
             set: {
@@ -199,6 +205,7 @@ private struct CLIDeliveryPolicyMetric: View {
 
 private struct CLIRegistrationTable: View {
     @Bindable var store: ControlPlaneStore
+    var edit: (String) -> Void
 
     var body: some View {
         Table(store.filteredCLIRegistrations, selection: $store.selectedCLI) {
@@ -247,16 +254,15 @@ private struct CLIRegistrationTable: View {
 
             TableColumn("") { item in
                 Button {
-                    store.selectedCLI = item.name
+                    edit(item.name)
                 } label: {
-                    Label("Details", systemImage: "sidebar.right")
-                        .labelStyle(.iconOnly)
+                    Label("Edit", systemImage: "slider.horizontal.3")
                 }
                 .buttonStyle(.borderless)
-                .help("Show details for \(item.name)")
-                .accessibilityLabel("Show details for \(item.name)")
+                .help("Edit delivery settings for \(item.name)")
+                .accessibilityLabel("Edit \(item.name)")
             }
-            .width(44)
+            .width(min: 86, ideal: 96)
         }
         .accessibilityLabel("Registered CLI delivery table")
     }
@@ -266,6 +272,18 @@ private struct CLIRegistrationTable: View {
     }
 }
 
+private struct CLIRegistrationEditorSheet: View {
+    @Bindable var store: ControlPlaneStore
+    @Binding var pendingUnregister: CLIRegistrationSummary?
+
+    var body: some View {
+        CLIRegistrationDetail(
+            store: store,
+            pendingUnregister: $pendingUnregister
+        )
+    }
+}
+
 private struct CLIDeliveryPolicyEditorSheet: View {
     @Bindable var store: ControlPlaneStore
     @Environment(\.dismiss) private var dismiss