COD-661: Rename relations to relationships

sciapanCA · sciapanCA · commit 316447be99c4 · 2026-04-02T20:40:49.000+02:00
diff --git a/smoke_test.py b/smoke_test.py
@@ -133,7 +133,7 @@ async def test_list_tools(self) -> bool:
             result = await self.session.list_tools()
             tools = result.tools
 
-            expected_tools = {"codebase_consultant", "get_data_sources", "codebase_search", "fetch_artifacts", "get_artifact_relations"}
+            expected_tools = {"codebase_consultant", "get_data_sources", "codebase_search", "fetch_artifacts", "get_artifact_relationships"}
             actual_tools = {tool.name for tool in tools}
 
             if expected_tools == actual_tools:
diff --git a/src/codealive_mcp_server.py b/src/codealive_mcp_server.py
@@ -26,7 +26,7 @@
 # Import core components
 from core import codealive_lifespan, setup_debug_logging
 from middleware import N8NRemoveParametersMiddleware
-from tools import codebase_consultant, get_data_sources, fetch_artifacts, codebase_search, get_artifact_relations
+from tools import codebase_consultant, get_data_sources, fetch_artifacts, codebase_search, get_artifact_relationships
 
 # Initialize FastMCP server with lifespan and enhanced system instructions
 mcp = FastMCP(
@@ -99,7 +99,7 @@ async def health_check(request: Request) -> JSONResponse:
 mcp.tool()(get_data_sources)
 mcp.tool()(codebase_search)
 mcp.tool()(fetch_artifacts)
-mcp.tool()(get_artifact_relations)
+mcp.tool()(get_artifact_relationships)
 
 
 def main():
diff --git a/src/tests/test_artifact_relationships.py b/src/tests/test_artifact_relationships.py
@@ -1,11 +1,11 @@
-"""Tests for the get_artifact_relations tool."""
+"""Tests for the get_artifact_relationships tool."""
 
 import pytest
 from unittest.mock import AsyncMock, MagicMock, patch
 
 from fastmcp import Context
 
-from tools.artifact_relations import get_artifact_relations, _build_relations_xml, PROFILE_MAP
+from tools.artifact_relationships import get_artifact_relationships, _build_relationships_xml, PROFILE_MAP
 
 
 class TestProfileMapping:
@@ -25,15 +25,15 @@ def test_references_only_maps_correctly(self):
         assert PROFILE_MAP["referencesOnly"] == "ReferencesOnly"
 
 
-class TestBuildRelationsXml:
-    """Test XML rendering of relation responses."""
+class TestBuildRelationshipsXml:
+    """Test XML rendering of relationship responses."""
 
-    def test_found_with_grouped_relations(self):
+    def test_found_with_grouped_relationships(self):
         data = {
             "sourceIdentifier": "org/repo::path::Symbol",
             "profile": "CallsOnly",
             "found": True,
-            "relations": [
+            "relationships": [
                 {
                     "relationType": "OutgoingCalls",
                     "totalCount": 57,
@@ -64,7 +64,7 @@ def test_found_with_grouped_relations(self):
             ],
         }
 
-        result = _build_relations_xml(data)
+        result = _build_relationships_xml(data)
 
         assert 'sourceIdentifier="org/repo::path::Symbol"' in result
         assert 'profile="callsOnly"' in result
@@ -86,21 +86,21 @@ def test_not_found_renders_self_closing(self):
             "sourceIdentifier": "org/repo::path::Missing",
             "profile": "CallsOnly",
             "found": False,
-            "relations": [],
+            "relationships": [],
         }
 
-        result = _build_relations_xml(data)
+        result = _build_relationships_xml(data)
 
         assert 'found="false"' in result
         assert result.endswith("/>")
-        assert "<relation_group" not in result
+        assert "<relationship_group" not in result
 
     def test_empty_group_still_rendered(self):
         data = {
             "sourceIdentifier": "org/repo::path::Symbol",
             "profile": "InheritanceOnly",
             "found": True,
-            "relations": [
+            "relationships": [
                 {
                     "relationType": "Ancestors",
                     "totalCount": 0,
@@ -118,7 +118,7 @@ def test_empty_group_still_rendered(self):
             ],
         }
 
-        result = _build_relations_xml(data)
+        result = _build_relationships_xml(data)
 
         assert 'type="ancestors"' in result
         assert 'type="descendants"' in result
@@ -129,7 +129,7 @@ def test_optional_fields_omitted_when_null(self):
             "sourceIdentifier": "org/repo::path::Symbol",
             "profile": "CallsOnly",
             "found": True,
-            "relations": [
+            "relationships": [
                 {
                     "relationType": "OutgoingCalls",
                     "totalCount": 1,
@@ -145,7 +145,7 @@ def test_optional_fields_omitted_when_null(self):
             ],
         }
 
-        result = _build_relations_xml(data)
+        result = _build_relationships_xml(data)
 
         assert 'identifier="org/repo::path::Target"' in result
         assert "filePath" not in result
@@ -157,7 +157,7 @@ def test_html_entities_escaped(self):
             "sourceIdentifier": "org/repo::path::Class<T>",
             "profile": "CallsOnly",
             "found": True,
-            "relations": [
+            "relationships": [
                 {
                     "relationType": "OutgoingCalls",
                     "totalCount": 1,
@@ -173,7 +173,7 @@ def test_html_entities_escaped(self):
             ],
         }
 
-        result = _build_relations_xml(data)
+        result = _build_relationships_xml(data)
 
         assert "Class&lt;T&gt;" in result
         assert "Method&lt;T&gt;" in result
@@ -187,17 +187,17 @@ def test_profile_mapped_back_to_mcp_name(self):
                 "sourceIdentifier": "id",
                 "profile": api_name,
                 "found": False,
-                "relations": [],
+                "relationships": [],
             }
-            result = _build_relations_xml(data)
+            result = _build_relationships_xml(data)
             assert f'profile="{mcp_name}"' in result
 
 
-class TestGetArtifactRelationsTool:
+class TestGetArtifactRelationshipsTool:
     """Test the async tool function."""
 
     @pytest.mark.asyncio
-    @patch("tools.artifact_relations.get_api_key_from_context")
+    @patch("tools.artifact_relationships.get_api_key_from_context")
     async def test_default_profile_sends_calls_only(self, mock_get_api_key):
         mock_get_api_key.return_value = "test_key"
 
@@ -210,7 +210,7 @@ async def test_default_profile_sends_calls_only(self, mock_get_api_key):
             "sourceIdentifier": "org/repo::path::Symbol",
             "profile": "CallsOnly",
             "found": True,
-            "relations": [],
+            "relationships": [],
         }
         mock_response.raise_for_status = MagicMock()
 
@@ -222,7 +222,7 @@ async def test_default_profile_sends_calls_only(self, mock_get_api_key):
         mock_context.base_url = "https://app.codealive.ai"
         ctx.request_context.lifespan_context = mock_context
 
-        result = await get_artifact_relations(
+        result = await get_artifact_relationships(
             ctx=ctx,
             identifier="org/repo::path::Symbol",
         )
@@ -233,7 +233,7 @@ async def test_default_profile_sends_calls_only(self, mock_get_api_key):
         assert 'found="true"' in result
 
     @pytest.mark.asyncio
-    @patch("tools.artifact_relations.get_api_key_from_context")
+    @patch("tools.artifact_relationships.get_api_key_from_context")
     async def test_explicit_profile_maps_correctly(self, mock_get_api_key):
         mock_get_api_key.return_value = "test_key"
 
@@ -246,7 +246,7 @@ async def test_explicit_profile_maps_correctly(self, mock_get_api_key):
             "sourceIdentifier": "id",
             "profile": "InheritanceOnly",
             "found": True,
-            "relations": [],
+            "relationships": [],
         }
         mock_response.raise_for_status = MagicMock()
 
@@ -258,7 +258,7 @@ async def test_explicit_profile_maps_correctly(self, mock_get_api_key):
         mock_context.base_url = "https://app.codealive.ai"
         ctx.request_context.lifespan_context = mock_context
 
-        await get_artifact_relations(
+        await get_artifact_relationships(
             ctx=ctx,
             identifier="id",
             profile="inheritanceOnly",
@@ -270,21 +270,21 @@ async def test_explicit_profile_maps_correctly(self, mock_get_api_key):
     @pytest.mark.asyncio
     async def test_empty_identifier_returns_error(self):
         ctx = MagicMock(spec=Context)
-        result = await get_artifact_relations(ctx=ctx, identifier="")
+        result = await get_artifact_relationships(ctx=ctx, identifier="")
         assert "<error>" in result
         assert "required" in result
 
     @pytest.mark.asyncio
     async def test_unsupported_profile_returns_error(self):
         ctx = MagicMock(spec=Context)
-        result = await get_artifact_relations(
+        result = await get_artifact_relationships(
             ctx=ctx, identifier="id", profile="invalidProfile"
         )
         assert "<error>" in result
         assert "Unsupported profile" in result
 
     @pytest.mark.asyncio
-    @patch("tools.artifact_relations.get_api_key_from_context")
+    @patch("tools.artifact_relationships.get_api_key_from_context")
     async def test_api_error_returns_error_xml(self, mock_get_api_key):
         import httpx
 
@@ -309,13 +309,13 @@ async def test_api_error_returns_error_xml(self, mock_get_api_key):
         mock_context.base_url = "https://app.codealive.ai"
         ctx.request_context.lifespan_context = mock_context
 
-        result = await get_artifact_relations(ctx=ctx, identifier="id")
+        result = await get_artifact_relationships(ctx=ctx, identifier="id")
 
         assert "<error>" in result
         assert "401" in result
 
     @pytest.mark.asyncio
-    @patch("tools.artifact_relations.get_api_key_from_context")
+    @patch("tools.artifact_relationships.get_api_key_from_context")
     async def test_not_found_response_renders_correctly(self, mock_get_api_key):
         mock_get_api_key.return_value = "test_key"
 
@@ -328,7 +328,7 @@ async def test_not_found_response_renders_correctly(self, mock_get_api_key):
             "sourceIdentifier": "org/repo::path::Missing",
             "profile": "CallsOnly",
             "found": False,
-            "relations": [],
+            "relationships": [],
         }
         mock_response.raise_for_status = MagicMock()
 
@@ -340,7 +340,7 @@ async def test_not_found_response_renders_correctly(self, mock_get_api_key):
         mock_context.base_url = "https://app.codealive.ai"
         ctx.request_context.lifespan_context = mock_context
 
-        result = await get_artifact_relations(ctx=ctx, identifier="org/repo::path::Missing")
+        result = await get_artifact_relationships(ctx=ctx, identifier="org/repo::path::Missing")
 
         assert 'found="false"' in result
-        assert "<relation_group" not in result
+        assert "<relationship_group" not in result
diff --git a/src/tests/test_fetch_artifacts.py b/src/tests/test_fetch_artifacts.py
@@ -95,15 +95,15 @@ def test_artifact_structure_has_content_child(self):
         assert "<content>" in result
 
 
-class TestBuildArtifactsXmlRelations:
-    """Test relations rendering in _build_artifacts_xml."""
+class TestBuildArtifactsXmlRelationships:
+    """Test relationships rendering in _build_artifacts_xml."""
 
-    def test_relations_with_outgoing_and_incoming(self):
+    def test_relationships_with_outgoing_and_incoming(self):
         data = {"artifacts": [{
             "identifier": "repo::src/a.ts::FuncA",
             "content": "code",
             "contentByteSize": 4,
-            "relations": {
+            "relationships": {
                 "outgoingCallsCount": 12,
                 "outgoingCalls": [
                     {"identifier": "repo::src/b.ts::FuncB", "summary": "Validates token"},
@@ -116,21 +116,21 @@ def test_relations_with_outgoing_and_incoming(self):
             }
         }]}
         result = _build_artifacts_xml(data)
-        assert "<relations>" in result
-        assert '</relations>' in result
+        assert "<relationships>" in result
+        assert '</relationships>' in result
         assert '<outgoing_calls count="12">' in result
         assert '</outgoing_calls>' in result
         assert '<incoming_calls count="3">' in result
         assert '</incoming_calls>' in result
         assert 'identifier="repo::src/b.ts::FuncB" summary="Validates token"' in result
         assert 'identifier="repo::src/d.ts::FuncD" summary="Entry point"' in result
 
-    def test_relations_with_only_outgoing(self):
+    def test_relationships_with_only_outgoing(self):
         data = {"artifacts": [{
             "identifier": "repo::src/a.ts::FuncA",
             "content": "code",
             "contentByteSize": 4,
-            "relations": {
+            "relationships": {
                 "outgoingCallsCount": 2,
                 "outgoingCalls": [
                     {"identifier": "repo::src/b.ts::FuncB", "summary": "Does stuff"},
@@ -140,36 +140,36 @@ def test_relations_with_only_outgoing(self):
             }
         }]}
         result = _build_artifacts_xml(data)
-        assert "<relations>" in result
+        assert "<relationships>" in result
         assert "<outgoing_calls" in result
         assert "<incoming_calls" not in result
 
-    def test_relations_null_omits_relations_element(self):
+    def test_relationships_null_omits_relationships_element(self):
         data = {"artifacts": [{
             "identifier": "repo::src/a.ts",
             "content": "code",
             "contentByteSize": 4,
-            "relations": None,
+            "relationships": None,
         }]}
         result = _build_artifacts_xml(data)
-        assert "<relations>" not in result
+        assert "<relationships>" not in result
         assert "<content>" in result
 
-    def test_relations_absent_omits_relations_element(self):
+    def test_relationships_absent_omits_relationships_element(self):
         data = {"artifacts": [{
             "identifier": "repo::src/a.ts",
             "content": "code",
             "contentByteSize": 4,
         }]}
         result = _build_artifacts_xml(data)
-        assert "<relations>" not in result
+        assert "<relationships>" not in result
 
-    def test_relations_call_without_summary_omits_summary_attr(self):
+    def test_relationships_call_without_summary_omits_summary_attr(self):
         data = {"artifacts": [{
             "identifier": "repo::src/a.ts::FuncA",
             "content": "code",
             "contentByteSize": 4,
-            "relations": {
+            "relationships": {
                 "outgoingCallsCount": 1,
                 "outgoingCalls": [
                     {"identifier": "repo::src/b.ts::FuncB", "summary": None},
@@ -182,12 +182,12 @@ def test_relations_call_without_summary_omits_summary_attr(self):
         assert 'identifier="repo::src/b.ts::FuncB"/>' in result
         assert 'summary' not in result.split('FuncB')[1].split('/>')[0]
 
-    def test_relations_escapes_xml_in_summary(self):
+    def test_relationships_escapes_xml_in_summary(self):
         data = {"artifacts": [{
             "identifier": "repo::src/a.ts::FuncA",
             "content": "code",
             "contentByteSize": 4,
-            "relations": {
+            "relationships": {
                 "outgoingCallsCount": 1,
                 "outgoingCalls": [
                     {"identifier": "repo::src/b.ts::FuncB", "summary": 'Checks if x < 10 & y > 5'},
diff --git a/src/tools/__init__.py b/src/tools/__init__.py
@@ -1,9 +1,9 @@
 """Tool implementations for CodeAlive MCP server."""
 
-from .artifact_relations import get_artifact_relations
+from .artifact_relationships import get_artifact_relationships
 from .chat import codebase_consultant
 from .datasources import get_data_sources
 from .fetch_artifacts import fetch_artifacts
 from .search import codebase_search
 
-__all__ = ['codebase_consultant', 'get_data_sources', 'fetch_artifacts', 'codebase_search', 'get_artifact_relations']
+__all__ = ['codebase_consultant', 'get_data_sources', 'fetch_artifacts', 'codebase_search', 'get_artifact_relationships']
diff --git a/src/tools/artifact_relationships.py b/src/tools/artifact_relationships.py
diff --git a/src/tools/fetch_artifacts.py b/src/tools/fetch_artifacts.py
